Skip to content

[TT-16960] Update pump an storage to support pgx v5 #8093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buger merged 3 commits into from
Apr 17, 2026

update pump an storage

12fe660
Select commit
Loading
Failed to load commit list.
Merged

[TT-16960] Update pump an storage to support pgx v5 #8093

update pump an storage
12fe660
Select commit
Loading
Failed to load commit list.
probelabs / Visor: quality failed Apr 17, 2026 in 42s

🚨 Check Failed

quality check failed because fail_if condition was met.

Details

📊 Summary

  • Total Issues: 3
  • Error Issues: 2
  • Warning Issues: 1

🔍 Failure Condition Results

Failed Conditions

  • global_fail_if: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')
    • Severity: ❌ error

Issues by Category

Documentation (1)

  • ❌ go.mod:1 - The pull request description is empty, failing to explain the purpose, context, and testing for the dependency updates. This violates the project's own checklist and prevents a meaningful review of the potential impact of these changes. The title mentions pgx v5 support, but no details are provided.

Architecture (1)

  • ⚠️ go.mod:34 - The tyk-pump dependency is updated to a release candidate version (v1.14.1-rc1). Release candidates are pre-release versions and are not generally considered stable for use in a main branch, as they may contain bugs or undergo further changes.

Logic (1)

  • ❌ system:0 - Global failure condition met: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')

Powered by Visor from Probelabs

💡 TIP: You can chat with Visor using /visor ask <your question>

Annotations

Check failure on line 1 in go.mod

See this annotation in the file changed.

@probelabs probelabs / Visor: quality

documentation Issue 

The pull request description is empty, failing to explain the purpose, context, and testing for the dependency updates. This violates the project's own checklist and prevents a meaningful review of the potential impact of these changes. The title mentions `pgx v5` support, but no details are provided.
Raw output 
Update the pull request description to detail why these dependencies are being updated, what the changes in the new versions are, and how this has been tested. Specifically, address the checklist item: "I explained why this PR updates go.mod in detail with reasoning why it's required".

Check warning on line 34 in go.mod

See this annotation in the file changed.

@probelabs probelabs / Visor: quality

architecture Issue 

The `tyk-pump` dependency is updated to a release candidate version (`v1.14.1-rc1`). Release candidates are pre-release versions and are not generally considered stable for use in a main branch, as they may contain bugs or undergo further changes.
Raw output 
If a stable version is available that includes the required changes, it should be preferred. If this specific release candidate is required, the reasoning and the risk assessment should be documented in the pull request description.
View more details on probelabs