Skip to content

fix: use Go 1.25 for dashboard builder step#8098

Merged
buger merged 1 commit intomasterfrom
fix/dashboard-builder-go125-master
Apr 20, 2026
Merged

fix: use Go 1.25 for dashboard builder step#8098
buger merged 1 commit intomasterfrom
fix/dashboard-builder-go125-master

Conversation

@buger
Copy link
Copy Markdown
Member

@buger buger commented Apr 20, 2026

Summary

  • The build-dashboard-image step used golang-cross:1.24-bookworm while everything else uses 1.25-bullseye
  • Updated to match the golang_cross matrix value

Test plan

  • build-dashboard-image step works when triggered

🤖 Generated with Claude Code

The build-dashboard-image step had golang-cross:1.24-bookworm
hardcoded while the goreleaser step uses 1.25-bullseye. This
version mismatch could cause build failures.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@buger buger requested a review from a team as a code owner April 20, 2026 08:18
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Jira Linter Failed

Commit: c303897
Failed at: 2026-04-20 08:19:28 UTC

The Jira linter failed to validate your PR. Please check the error details below:

🔍 Click to view error details
failed to validate branch and PR title rules: branch name 'fix/dashboard-builder-go125-master' must contain a valid Jira ticket ID (e.g., ABC-123)

Next Steps

  • Ensure your branch name contains a valid Jira ticket ID (e.g., ABC-123)
  • Verify your PR title matches the branch's Jira ticket ID
  • Check that the Jira ticket exists and is accessible

This comment will be automatically deleted once the linter passes.

@probelabs
Copy link
Copy Markdown
Contributor

probelabs bot commented Apr 20, 2026

This pull request updates the Go version for the dashboard builder step within the CI/CD release workflow.

Files Changed Analysis

  • .github/workflows/release.yml: A single line was changed to update the Docker image from tykio/golang-cross:1.24-bookworm to tykio/golang-cross:1.25-bullseye.

Architecture & Impact Assessment

  • Accomplishment: This PR standardizes the Go version used in the build-dashboard-image job, aligning it with other build steps in the release pipeline.
  • Key Technical Changes: The core change is the version bump of the golang-cross Docker image used for building the Tyk Dashboard component.
  • Affected Components: The change impacts the continuous integration and deployment pipeline, specifically the release workflow. It ensures a consistent build environment, reducing the risk of compatibility issues arising from using different Go versions.

Scope Discovery & Context Expansion

  • The change is narrowly scoped to the build environment configuration for a specific job within the release.yml workflow. It does not alter any application source code. The primary motivation is to resolve an inconsistency in the build tooling versions, as noted in the PR description.
Metadata
  • Review Effort: 1 / 5
  • Primary Label: chore

Powered by Visor from Probelabs

Last updated: 2026-04-20T08:20:09.935Z | Triggered by: pr_opened | Commit: c303897

💡 TIP: You can chat with Visor using /visor ask <your question>

@probelabs
Copy link
Copy Markdown
Contributor

probelabs bot commented Apr 20, 2026

Security Issues (1)

Severity Location Issue
🟡 Warning .github/workflows/release.yml:734
The Docker image `tykio/golang-cross:1.25-bullseye` is referenced using a mutable tag. This practice can lead to non-reproducible builds and creates a supply chain risk. If the tag is ever updated, intentionally or maliciously, the build pipeline could pull a different image than intended, potentially introducing vulnerabilities or breaking changes into the release process.
💡 SuggestionPin the Docker image to its immutable content digest (SHA256 hash) to ensure the exact same image is used for every build. You can retrieve the digest after pulling the image with `docker inspect tykio/golang-cross:1.25-bullseye` and then update the workflow to use the format `tykio/golang-cross:1.25-bullseye@sha256:<digest-hash>`.

✅ Architecture Check Passed

No architecture issues found – changes LGTM.

✅ Performance Check Passed

No performance issues found – changes LGTM.


Powered by Visor from Probelabs

Last updated: 2026-04-20T08:20:08.233Z | Triggered by: pr_opened | Commit: c303897

💡 TIP: You can chat with Visor using /visor ask <your question>

@github-actions
Copy link
Copy Markdown
Contributor

API Changes

no api changes detected

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@buger buger merged commit 9cccaf4 into master Apr 20, 2026
53 of 56 checks passed
@buger buger deleted the fix/dashboard-builder-go125-master branch April 20, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant