Skip to content

fix: use Go 1.25 for dashboard builder step#8101

Merged
buger merged 1 commit intorelease-5.12.1from
fix/dashboard-builder-go125-5.12.1-clean
Apr 20, 2026
Merged

fix: use Go 1.25 for dashboard builder step#8101
buger merged 1 commit intorelease-5.12.1from
fix/dashboard-builder-go125-5.12.1-clean

Conversation

@buger
Copy link
Copy Markdown
Member

@buger buger commented Apr 20, 2026

Summary

The build-dashboard-image step had golang-cross:1.24-bookworm hardcoded while goreleaser uses 1.25-bullseye. Updated to match.

Test plan

  • build-dashboard-image step works when triggered

🤖 Generated with Claude Code

The build-dashboard-image step had golang-cross:1.24-bookworm
hardcoded while the goreleaser step uses 1.25-bullseye.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@buger buger requested a review from a team as a code owner April 20, 2026 08:59
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Jira Linter Failed

Commit: b0ca559
Failed at: 2026-04-20 09:00:20 UTC

The Jira linter failed to validate your PR. Please check the error details below:

🔍 Click to view error details
failed to validate branch and PR title rules: branch name 'fix/dashboard-builder-go125-5.12.1-clean' must contain a valid Jira ticket ID (e.g., ABC-123)

Next Steps

  • Ensure your branch name contains a valid Jira ticket ID (e.g., ABC-123)
  • Verify your PR title matches the branch's Jira ticket ID
  • Check that the Jira ticket exists and is accessible

This comment will be automatically deleted once the linter passes.

@probelabs
Copy link
Copy Markdown
Contributor

probelabs bot commented Apr 20, 2026

This PR updates the Go version for the dashboard builder step in the release workflow, aligning it with the version used by GoReleaser to ensure build consistency.

Files Changed Analysis

  • .github/workflows/release.yml: (1 addition, 1 deletion)
    • The Docker image for the build-dashboard-image step was updated from tykio/golang-cross:1.24-bookworm to tykio/golang-cross:1.25-bullseye.

Architecture & Impact Assessment

  • What this PR accomplishes: It resolves an inconsistency in the CI/CD pipeline where the dashboard was built with a different Go version (1.24) than the rest of the project components handled by GoReleaser (1.25).
  • Key technical changes introduced: A single line change in the GitHub Actions workflow configuration to specify a newer version of the golang-cross Docker image.
  • Affected system components: The change is strictly limited to the CI/CD release pipeline. It has no impact on the runtime application code or its architecture.

Scope Discovery & Context Expansion

  • The impact is confined to the release process, improving its reliability by ensuring a consistent build environment. This change mitigates potential issues arising from using different patch versions or distributions of Go during the creation of release artifacts.
Metadata
  • Review Effort: 1 / 5
  • Primary Label: bug

Powered by Visor from Probelabs

Last updated: 2026-04-20T09:00:58.174Z | Triggered by: pr_opened | Commit: b0ca559

💡 TIP: You can chat with Visor using /visor ask <your question>

@buger buger merged commit 604a54d into release-5.12.1 Apr 20, 2026
18 of 19 checks passed
@probelabs
Copy link
Copy Markdown
Contributor

probelabs bot commented Apr 20, 2026

Security Issues (1)

Severity Location Issue
🟡 Warning .github/workflows/release.yml:717
The build environment's base OS is being downgraded from Debian Bookworm (stable) to Debian Bullseye (oldstable). While the Go version is updated, using an older OS base can introduce security risks if vulnerabilities patched in the newer version are present. This could potentially expose the build process to supply chain vulnerabilities.
💡 SuggestionWhile the goal of aligning with the goreleaser environment is understood, using an older OS version is not ideal. Investigate if a `tykio/golang-cross:1.25-bookworm` image can be created and used. Alternatively, plan to upgrade the entire build toolchain, including goreleaser, to use a more recent base image like Debian Bookworm to maintain a secure build environment.

✅ Architecture Check Passed

No architecture issues found – changes LGTM.

✅ Performance Check Passed

No performance issues found – changes LGTM.


Powered by Visor from Probelabs

Last updated: 2026-04-20T09:00:52.936Z | Triggered by: pr_opened | Commit: b0ca559

💡 TIP: You can chat with Visor using /visor ask <your question>

@buger buger deleted the fix/dashboard-builder-go125-5.12.1-clean branch April 20, 2026 09:00
@github-actions
Copy link
Copy Markdown
Contributor

API Changes

no api changes detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant