Skip to content

Merging to release-5.13.0: [TT-17154] Bump opentelemetry to post-v0.0.25 doc-comment fixes (#8240)#8250

Merged
mativm02 merged 5 commits into
release-5.13.0from
merge/release-5.13.0/TT-17154
May 28, 2026
Merged

Merging to release-5.13.0: [TT-17154] Bump opentelemetry to post-v0.0.25 doc-comment fixes (#8240)#8250
mativm02 merged 5 commits into
release-5.13.0from
merge/release-5.13.0/TT-17154

Conversation

@mativm02

@mativm02 mativm02 commented May 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Cherry-pick of #8240 onto release-5.13.0.

Bumps github.com/TykTechnologies/opentelemetry from v0.0.25 to v0.0.26-0.20260521112223-3b0d024e6090, pulling in doc-comment fixes (TykTechnologies/opentelemetry#69). Documentation-only upstream change — no behavior, API, or default changes.

Follow-up to #8235 (the docs update that already landed on release-5.13.0), bringing the matching gateway-side library bump.

Test plan

  • CI green on this branch

Ticket Details

TT-17154
Status In Code Review
Summary Gateway API + config 5.13.0

Generated at: 2026-05-28 19:25:56

## Summary

- Bumps `github.com/TykTechnologies/opentelemetry` from `v0.0.25` to
`v0.0.26-0.20260521112223-3b0d024e6090`, pulling in
[opentelemetry#69](TykTechnologies/opentelemetry#69)
(merge commit `3b0d024e`).
- That PR is a documentation-only change: it clarifies the config struct
comments that drive user-facing OpenTelemetry docs generation
(`ExporterConfig.Exporter`, `ResourceName`, `OpenTelemetry.Enabled`,
`TLS.Enable`, `TLS.CAFile`). No behavior, API, or default changes.
- Pinned via Go pseudo-version because no new tag was cut after
`v0.0.25` for this commit.

## Motivation

PR review feedback on the gateway-side OpenTelemetry config docs noted
unclear/inconsistent wording and grammar issues. Since the docs are
generated from the upstream library's struct comments, the fixes live in
`TykTechnologies/opentelemetry`. This PR brings those fixes into the
gateway.

## Test plan

- [x] `go build ./...` — OTel-touching packages (`./internal/otel/...`,
`./internal/graphql/...`, `./gateway/...`) compile clean. The only build
noise (`test/goplugins` "main undeclared", linker duplicate `-ldl`
warning) is pre-existing on master and unrelated.
- [x] `go vet ./internal/otel/...` — passes.
- [x] `go mod tidy` — clean, no unrelated module churn.
- [ ] CI green on this branch.

## Notes for reviewers

- Since the upstream change is comment-only, the diff here is minimal (2
lines in `go.mod`, 4 in `go.sum`).
- Once a `v0.0.26` tag is cut on the opentelemetry repo, a follow-up can
replace the pseudo-version with the clean tag — but functionally
identical.
<!---TykTechnologies/jira-linter starts here-->

### Ticket Details

<details>
<summary>
<a href="https://tyktech.atlassian.net/browse/TT-17154" title="TT-17154"
target="_blank">TT-17154</a>
</summary>

|         |    |
|---------|----|
| Status  | In Code Review |
| Summary | Gateway API + config 5.13.0 |

Generated at: 2026-05-21 11:53:06

</details>

<!---TykTechnologies/jira-linter ends here-->

(cherry picked from commit 8a9a180)
@mativm02
mativm02 enabled auto-merge (squash) May 26, 2026 12:02
@probelabs

probelabs Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

This pull request cherry-picks a dependency update for github.com/TykTechnologies/opentelemetry onto the release-5.13.0 branch, bumping it from v0.0.25 to v0.0.26-0.20260521112223-3b0d024e6090.

The upstream change in the opentelemetry library is purely for documentation and introduces no behavioral, API, or default configuration changes. This PR aligns the gateway's dependency with documentation updates that have already been merged into the release branch.

Files Changed Analysis

The changes are confined to Go's dependency management files:

  • go.mod: Updates the required version for github.com/TykTechnologies/opentelemetry.
  • go.sum: Updates the checksums to match the new version of the dependency.
    This pattern is standard for a routine dependency bump.

Architecture & Impact Assessment

  • What this PR accomplishes: It synchronizes the opentelemetry dependency version on the release-5.13.0 branch with its corresponding documentation, ensuring consistency.
  • Key technical changes introduced: The version constraint for a single Go module is updated in go.mod.
  • Affected system components: The change impacts the dependency resolution and build process. As the underlying library update is documentation-only, there is no risk to the gateway's runtime behavior, particularly its telemetry and tracing subsystems. The overall impact is negligible.

Scope Discovery & Context Expansion

Metadata
  • Review Effort: 1 / 5
  • Primary Label: chore

Powered by Visor from Probelabs

Last updated: 2026-05-28T19:26:55.554Z | Triggered by: pr_updated | Commit: 4831a28

💡 TIP: You can chat with Visor using /visor ask <your question>

@probelabs

probelabs Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

✅ Architecture Check Passed

No architecture issues found – changes LGTM.

✅ Performance Check Passed

No performance issues found – changes LGTM.

\n\n

✅ Architecture Check Passed

No architecture issues found – changes LGTM.

\n\n

✅ Performance Check Passed

No performance issues found – changes LGTM.

\n\n

✅ Quality Check Passed

No quality issues found – changes LGTM.


Powered by Visor from Probelabs

Last updated: 2026-05-28T19:26:29.637Z | Triggered by: pr_updated | Commit: 4831a28

💡 TIP: You can chat with Visor using /visor ask <your question>

@mativm02 mativm02 added the deps-reviewed Dependency changes reviewed and approved for CI execution label May 26, 2026
mativm02 added a commit that referenced this pull request May 28, 2026
## Summary

Re-applies the one-line workflow timeout bump from Ilija's #8156 (commit
`edfe152a0`) which is currently regressed on `release-5.13.0`.

| Branch | `Run API tests` `timeout-minutes` |
|---|---|
| `release-5.13` | 40 |
| `release-5.13.0` | 30 (regressed) |
| `master` | 40 |

`edfe152a0` is present in `release-5.13.0`'s history, but later
FIPS-related PRs (`9d14d228b` disable FIPS / `1d51bf98d` re-enable FIPS)
rewrote the workflow and ended up restoring 30m.

## Evidence

api-tests on PR #8250 currently fail with `##[error]The action has timed
out.` after exactly 30 minutes. Tests took 32-33min on that run — they
would have passed under 40m.

## Test plan

- [ ] CI green on this branch
- [ ] api-tests step on dependent PRs (#8250 etc) completes without
timeout
<!---TykTechnologies/jira-linter starts here-->

### Ticket Details

<details>
<summary>
<a href="https://tyktech.atlassian.net/browse/TT-17077" title="TT-17077"
target="_blank">TT-17077</a>
</summary>

|         |    |
|---------|----|
| Status  | Closed |
| Summary | CI/CD: Increase timeout for API tests job |

Generated at: 2026-05-28 15:49:07

</details>

<!---TykTechnologies/jira-linter ends here-->
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mativm02
mativm02 merged commit 8e1b29d into release-5.13.0 May 28, 2026
77 of 86 checks passed
@mativm02
mativm02 deleted the merge/release-5.13.0/TT-17154 branch May 28, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps-reviewed Dependency changes reviewed and approved for CI execution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant