Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the portfolio’s static asset delivery to better handle Git LFS-managed binaries and improve reliability of containerized deployments by building the React app into a static bundle served by Nginx.
Changes:
- Add a cache-busting query parameter for
/skills/*images rendered bySoftwareSkill. - Introduce a Git LFS pointer verification script and run it during Docker image build.
- Switch Docker runtime from
npm start(Node) to serving the built bundle via Nginx (with a customnginx.conf).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/softwareSkills/SoftwareSkill.js | Adds a version query param to skill image URLs for cache busting. |
| scripts/verify-lfs-assets.js | Adds a build-time check to fail fast if Git LFS assets are still pointers. |
| package-lock.json | Lockfile update (adds nested yaml dependency entry). |
| nginx.conf | Adds SPA routing + static asset caching rules for Nginx. |
| Dockerfile | Converts to multi-stage build: build React app in Node, serve via Nginx. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const fs = require("fs"); | ||
| const path = require("path"); | ||
|
|
||
| const assetRoots = ["public", path.join("src", "assests")]; |
Comment on lines
+12
to
+15
| location ^~ /skills/ { | ||
| add_header Cache-Control "no-cache"; | ||
| try_files $uri =404; | ||
| } |
Comment on lines
+5
to
+6
| const skillAssetVersion = "2026-06-29-lfs-refresh"; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.