WI #2727 Improve insertText for variables located under OCCURS#2793
Merged
efr15 merged 4 commits intoJul 25, 2025
Merged
Conversation
fm-117
requested changes
Jul 22, 2025
Contributor
|
My fear is that this PR won't help users much and it may even hinder them sometimes as we don't have robust logic to know whether to subscript or not. |
added 3 commits
July 23, 2025 15:02
fm-117
self-requested a review
July 24, 2025 07:06
fm-117
approved these changes
Jul 24, 2025
efr15
deleted the
2727-improve-inserttext-for-variables-located-under-occurs
branch
July 25, 2025 07:10
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2727
One LSR completion test was targeting a variable in an OCCURS => adapt it
Subscript is added for every statement except SEARCH and SORT.