Skip to content

WI #2232 Limit probability of InvalidOperationException during preprocessing step#2816

Closed
fm-117 wants to merge 2 commits into
developfrom
2232-invalidoperationexception-in-selectalltokensbetween-method
Closed

WI #2232 Limit probability of InvalidOperationException during preprocessing step#2816
fm-117 wants to merge 2 commits into
developfrom
2232-invalidoperationexception-in-selectalltokensbetween-method

Conversation

@fm-117

@fm-117 fm-117 commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

Ok this is not a fix but rather an attempt to limit uses of SelectAllTokensBetween.

As our logs show that the method was invoked on tokens that should not participate in a CompilerDirective building, it means that something very wrong happened... However the directive builder should also not create anything in that case so the method should not be called with this new code.

@fm-117
fm-117 requested a review from efr15 November 25, 2025 07:52
@fm-117 fm-117 self-assigned this Nov 25, 2025
@fm-117
fm-117 marked this pull request as draft November 25, 2025 08:18
@fm-117

fm-117 commented Nov 25, 2025

Copy link
Copy Markdown
Contributor Author

Converting to draft as we still have to find the original cause...

@fm-117

fm-117 commented Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

Replaced by #2821

@fm-117 fm-117 closed this Dec 3, 2025
@fm-117
fm-117 deleted the 2232-invalidoperationexception-in-selectalltokensbetween-method branch December 3, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant