Skip to content

WI #2817 Prevent from NullReferenceException in completion after IN/OF#2820

Merged
fm-117 merged 4 commits into
developfrom
2817-nullreferenceexception-in-symboltablegetvariablesfuncdatadefinition-bool-scope
Dec 9, 2025
Merged

WI #2817 Prevent from NullReferenceException in completion after IN/OF#2820
fm-117 merged 4 commits into
developfrom
2817-nullreferenceexception-in-symboltablegetvariablesfuncdatadefinition-bool-scope

Conversation

@efr15

@efr15 efr15 commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

Fixes #2817

I cannot reproduce the problem.
However we see that we cannot add a null symbol or a symbol with null name in the symbol table (cf SymbolTable.AddVariable).
Therefore, it is very likely that the right-hand side of the predicate is null, i.e. firstVariableName.

@efr15
efr15 requested a review from fm-117 November 26, 2025 14:35
@efr15 efr15 self-assigned this Nov 26, 2025
Comment thread TypeCobol.LanguageServer/Completion Factory/CompletionForInOrOf.cs Outdated
@efr15
efr15 requested a review from fm-117 December 8, 2025 15:01
@fm-117
fm-117 merged commit e963739 into develop Dec 9, 2025
8 checks passed
@fm-117
fm-117 deleted the 2817-nullreferenceexception-in-symboltablegetvariablesfuncdatadefinition-bool-scope branch December 9, 2025 09:50
@fm-117 fm-117 mentioned this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NullReferenceException in SymbolTable.GetVariables(Func<DataDefinition, bool>, Scope)

2 participants