Skip to content

WI #2850 Check wrong values on an OCCURS clause#2854

Merged
Finou1404 merged 2 commits into
developfrom
2850-missing-check-on-min-and-max-occurrence
May 29, 2026
Merged

WI #2850 Check wrong values on an OCCURS clause#2854
Finou1404 merged 2 commits into
developfrom
2850-missing-check-on-min-and-max-occurrence

Conversation

@Finou1404

@Finou1404 Finou1404 commented May 13, 2026

Copy link
Copy Markdown
Contributor

Fixes #2850

@Finou1404
Finou1404 requested review from efr15 and fm-117 May 13, 2026 14:18
@Finou1404 Finou1404 self-assigned this May 13, 2026
@Finou1404 Finou1404 linked an issue May 13, 2026 that may be closed by this pull request
Comment thread TypeCobol/Compiler/Nodes/Data.cs Outdated
Comment thread TypeCobol/Compiler/Nodes/Data.cs Outdated
@efr15

efr15 commented May 15, 2026

Copy link
Copy Markdown
Contributor

Could you please add the mention Fixes #2850 in the PR description? Thanks.

Comment thread TypeCobol.Test/Parser/Programs/Cobol85/OccursWrongValues.CodeElements.txt Outdated
Comment thread TypeCobol/Compiler/Diagnostics/CodeElementCheckers.cs Outdated
Comment thread TypeCobol/Compiler/Diagnostics/CodeElementCheckers.cs Outdated
@Finou1404
Finou1404 requested review from efr15 and fm-117 May 28, 2026 08:58

// Check Max value cannot be zero or negative
var maxOcc = codeElement.MaxOccurencesCount?.Value;
if (maxOcc <= 0 ) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unwanted space between 0 and )

@Finou1404
Finou1404 merged commit d77277c into develop May 29, 2026
8 checks passed
@Finou1404
Finou1404 deleted the 2850-missing-check-on-min-and-max-occurrence branch May 29, 2026 13:29
@efr15 efr15 mentioned this pull request Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing check on min and max Occurrence

3 participants