Implement linking optimizations - #144
Open
msujew wants to merge 2 commits into
Open
Conversation
msujew
force-pushed
the
msujew/linking-optimizations
branch
from
August 22, 2026 09:59
02a4819 to
9b6fed2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linking phase is usually the most performance intensive phase. This is an attempt to improve its performance by reducing the amount of allocations performed during the linking.
The main improvement is concerned with the new
SymbolSliceContainer. Adopters (or the generated<Language>SymbolContainer) can implement this to generate allocation free scopes.Another major improvement is the reduction of per-reference allocations. Mainly the new context that we generate for linking. It's now a single context with a special
resolutionChainattached to it that keeps track of cycles. Adds aForEachWithSetupfor this, which keeps one setup function per worker.Then there are a few other improvements:
nameof a symbol on the symbol description directly. This reduces the need for interface dispatches (expensive).GOMAXPROCSon everyForEachcall had to acquire a lock first internally.All of these changes together roughly double the performance of the workspace build.