Feat: add "yes all" option to overwrite style dialogs #234
+71
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FichteFoll
reviewed
Dec 25, 2024
Totto16
force-pushed
the
add_yes_all_to_style_dialog
branch
from
542b263 to
85df0f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a third option to all style dialogs, that when clicked overwrite all conflicts.
This is really helpful, since sometimes you update styles in sub files, and then you have to click multiple times "Yes", but a "Yes, all" option is present in many programs / dialogs (e.g. file move / copy dialogs) in many ways.
This PR needs some changes to the translation too, but that are some rather big changes in all
.pofiles, and if I runmake_pot.shit really scrambles things around, which is really frustrating, since the actual changes are not that visible (it should remove three strings and add 4 new ones). So I'll need help on how to approach that. 😄Feel free to leave comments on the feature / the implementation of it 😄
Here a screenshot of the new Feature (in german, that I already did here as this current version crashes locally, for an unrelated reason 😄 )
