Add 20px, 40px bitmaps; Regenerate all icon bitmaps #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0tkl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #315. Because it's been a long time, I'd like to repeat it: my motivation was to generate 20px bitmaps because a 16px toolbar was too small for me, while 24px was too large.
I then tried updating the existing bitmap sizes with similar code and found they looked slightly clearer (thanks to a good amount of ringing effect), so I'm posting those as well. Note that this PR did not touch the two icons mentioned in #496 to avoid conflicts. The current results are still far from perfect, mainly because text in small bitmaps is still blurry. For a truly excellent visual experience, I estimate we'll have to manually create those mini bitmap texts.
The new resolution added in this PR isn't limited to the single option. I welcome feedback from people using various resolutions on what icon sizes are most suitable for them.