Fix "Lowest Quality" Option Selects "Highest Quality" Instead of 144p

[Copilot]

Summary

Fixed issue #759 where selecting "Lowest Quality" option was downloading the highest quality (2160p) instead of the lowest (144p).

Closes #759

Bug Description

When users selected "Lowest Quality" preference for video downloads, the application incorrectly downloaded the highest available quality (e.g., 2160p) instead of the lowest available quality (e.g., 144p).

Root Cause

In VideoDownloadPreference.cs line 43, the Lowest quality preference case was using LastOrDefault() instead of FirstOrDefault().

Since the options are ordered by o.VideoQuality in ascending order (line 19):

• FirstOrDefault() returns the lowest quality ✓
• LastOrDefault() returns the highest quality ✗ (bug)

Fix Applied

Changed line 43 from:

VideoQualityPreference.Lowest => orderedOptions.LastOrDefault(o =>
    o.Container == PreferredContainer
),

To:

VideoQualityPreference.Lowest => orderedOptions.FirstOrDefault(o =>
    o.Container == PreferredContainer
),

Validation

• ✅ Build successful with no errors or warnings
• ✅ Logic is now consistent: Lowest uses FirstOrDefault(), Highest uses LastOrDefault()
• ✅ Security scan passed with no issues
• ✅ Minimal one-word change fixes the bug

This fix ensures that selecting "Lowest Quality" will now correctly download the lowest available quality (e.g., 144p) instead of the highest quality (e.g., 2160p).

Original prompt

can you investigate #729?

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Tyrrrz]

@copilot my bad I meant to ask you to investigate #759 instead of #729. Can you do that issue instead? You can reuse this PR

[Copilot]

@copilot my bad I meant to ask you to investigate #759 instead of #729. Can you do that issue instead? You can reuse this PR

Done! Issue #759 investigated and fixed in commit d720379.

The bug was in VideoDownloadPreference.cs line 43: Lowest was using LastOrDefault() instead of FirstOrDefault(), causing it to select the highest quality instead of the lowest. Changed to FirstOrDefault() to correctly select the lowest quality option.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• av-build-tel-api-v1.avaloniaui.net
  • Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/0.0.31/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/0.0.31/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

Fixes issue #759 where selecting the “Lowest quality” video preference incorrectly selected the highest available quality.

Changes:

• Adjusted VideoQualityPreference.Lowest selection logic to use the first ordered option rather than the last.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

orderedOptions is built from options.OrderBy(o => o.VideoQuality), and audio-only options have VideoQuality == null (see VideoDownloadOption.VideoQuality), which will sort first. Switching Lowest to FirstOrDefault can therefore select an audio-only option that shares the same container (e.g., Container.Mp4 has an audio-only option), resulting in downloading audio-only instead of the lowest video quality. Consider filtering out audio-only options here (e.g., require !o.IsAudioOnly / o.VideoQuality is not null) when PreferredContainer.IsAudioOnly is false, so Lowest picks the lowest video stream option for that container.