Skip to content

Conversation

itisAliRH
Copy link

@itisAliRH itisAliRH commented Apr 16, 2025

This PR addresses the following build issues encountered during the production build process (npm run production).
image

Changes Made

  • Added @popperjs/core as a dependency.
  • Updated Vue to version 3.5.13 and added @vue/compiler-sfc.
  • Removed direct Vue import from mixins.js.
  • Updated VueLoaderPlugin import in webpack.common.js to use the new syntax.
  • Cleaned up webpack configuration by removing unnecessary alias for Vue.

stweil added 30 commits March 13, 2025 10:12
The Python module opensearch-py is newer and well maintained.
It supports Elasticsearch and OpenSearch databases.

The new code uses "Elasticsearch/OpenSearch" in messages and replaces
"ESCRIPTORIUM" in several settings by "ES" which now means eScriptorium:

DISABLE_ELASTICSEARCH -> DISABLE_ES_SEARCH
ELASTICSEARCH_COMMON_INDEX -> ES_SEARCH_COMMON_INDEX
ELASTICSEARCH_URL -> ES_SEARCH_URL

Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
stweil and others added 11 commits March 13, 2025 10:12
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Bumps [ws](https://github.com/websockets/ws) from 8.12.0 to 8.18.1.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.12.0...8.18.1)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.13 to 6.2.1.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v6.1.13...v6.2.1)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pug](https://github.com/pugjs/pug) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/pugjs/pug/releases)
- [Commits](https://github.com/pugjs/pug/compare/[email protected]@3.0.3)

---
updated-dependencies:
- dependency-name: pug
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the npm_and_yarn group with 12 updates in the /front directory:

| Package | From | To |
| --- | --- | --- |
| [axios](https://github.com/axios/axios) | `0.21.4` | `1.8.2` |
| [bootstrap](https://github.com/twbs/bootstrap) | `4.5.3` | `5.3.3` |
| [vue](https://github.com/vuejs/core) | `2.7.16` | `3.0.0` |
| [vue-loader](https://github.com/vuejs/vue-loader) | `15.11.1` | `17.4.2` |
| [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials) | `6.5.16` | `8.6.4` |
| [@storybook/vue](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/vue) | `6.5.16` | `7.6.17` |
| [webpack](https://github.com/webpack/webpack) | `5.91.0` | `5.98.0` |
| [body-parser](https://github.com/expressjs/body-parser) | `1.20.2` | `1.20.3` |
| [express](https://github.com/expressjs/express) | `4.19.2` | `4.21.2` |
| [elliptic](https://github.com/indutny/elliptic) | `6.5.5` | `6.6.1` |
| [nanoid](https://github.com/ai/nanoid) | `3.3.7` | `3.3.9` |
| [store2](https://github.com/nbubna/store) | `2.14.2` | `2.14.4` |



Updates `axios` from 0.21.4 to 1.8.2
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v0.21.4...v1.8.2)

Updates `bootstrap` from 4.5.3 to 5.3.3
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](twbs/bootstrap@v4.5.3...v5.3.3)

Updates `vue` from 2.7.16 to 3.0.0
- [Release notes](https://github.com/vuejs/core/releases)
- [Changelog](https://github.com/vuejs/core/blob/v3.0.0/CHANGELOG.md)
- [Commits](https://github.com/vuejs/core/commits/v3.0.0)

Updates `vue-loader` from 15.11.1 to 17.4.2
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/main/CHANGELOG.md)
- [Commits](vuejs/vue-loader@v15.11.1...v17.4.2)

Updates `@storybook/addon-essentials` from 6.5.16 to 8.6.4
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.4/code/addons/essentials)

Updates `@storybook/vue` from 6.5.16 to 7.6.17
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/v7.6.17/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v7.6.17/code/renderers/vue)

Updates `webpack` from 5.91.0 to 5.98.0
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.91.0...v5.98.0)

Updates `postcss` from 7.0.39 to 8.4.38
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@7.0.39...8.4.38)

Updates `webpack-dev-middleware` from 3.7.3 to 4.3.0
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/master/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v3.7.3...v4.3.0)

Updates `body-parser` from 1.20.2 to 1.20.3
- [Release notes](https://github.com/expressjs/body-parser/releases)
- [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md)
- [Commits](expressjs/body-parser@1.20.2...1.20.3)

Updates `express` from 4.19.2 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.19.2...4.21.2)

Updates `cookie` from 0.6.0 to 0.7.1
- [Release notes](https://github.com/jshttp/cookie/releases)
- [Commits](jshttp/cookie@v0.6.0...v0.7.1)

Updates `cross-spawn` from 6.0.5 to 7.0.6
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v6.0.5...v7.0.6)

Updates `elliptic` from 6.5.5 to 6.6.1
- [Commits](indutny/elliptic@v6.5.5...v6.6.1)

Updates `express` from 4.19.2 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.19.2...4.21.2)

Updates `nanoid` from 3.3.7 to 3.3.9
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.7...3.3.9)

Updates `path-to-regexp` from 0.1.7 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.7...v0.1.12)

Updates `send` from 0.18.0 to 0.19.0
- [Release notes](https://github.com/pillarjs/send/releases)
- [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md)
- [Commits](pillarjs/send@0.18.0...0.19.0)

Updates `serve-static` from 1.15.0 to 1.16.2
- [Release notes](https://github.com/expressjs/serve-static/releases)
- [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md)
- [Commits](expressjs/serve-static@v1.15.0...v1.16.2)

Updates `store2` from 2.14.2 to 2.14.4
- [Commits](nbubna/store@2.14.2...2.14.4)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
  dependency-group: npm_and_yarn
- dependency-name: bootstrap
  dependency-type: direct:production
  dependency-group: npm_and_yarn
- dependency-name: vue
  dependency-type: direct:production
  dependency-group: npm_and_yarn
- dependency-name: vue-loader
  dependency-type: direct:production
  dependency-group: npm_and_yarn
- dependency-name: "@storybook/addon-essentials"
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: "@storybook/vue"
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: webpack
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: postcss
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: webpack-dev-middleware
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: body-parser
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: express
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: cookie
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: cross-spawn
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: elliptic
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: express
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: nanoid
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: path-to-regexp
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: send
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: serve-static
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: store2
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the npm_and_yarn group with 3 updates in the /front directory: [axios](https://github.com/axios/axios), [vue](https://github.com/vuejs/core) and [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers).


Updates `axios` from 1.8.2 to 1.8.3
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.8.2...v1.8.3)

Updates `vue` from 3.0.0 to 3.0.1
- [Release notes](https://github.com/vuejs/core/releases)
- [Changelog](https://github.com/vuejs/core/blob/v3.0.1/CHANGELOG.md)
- [Commits](vuejs/core@v3.0.0...v3.0.1)

Updates `@babel/helpers` from 7.20.7 to 7.26.10
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-helpers)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
  dependency-group: npm_and_yarn
- dependency-name: vue
  dependency-type: direct:production
  dependency-group: npm_and_yarn
- dependency-name: "@babel/helpers"
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
- Added @popperjs/core as a dependency.
- Updated Vue to version 3.5.13 and added @vue/compiler-sfc.
- Removed direct Vue import from mixins.js.
- Updated VueLoaderPlugin import in webpack.common.js to use the new syntax.
- Cleaned up webpack configuration by removing unnecessary alias for Vue.
},
"dependencies": {
"@fortawesome/fontawesome-free": "^5.7.0",
"@popperjs/core": "^2.11.8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this dependency needed? There is already an entry for popper.js.

@stweil
Copy link
Member

stweil commented Apr 17, 2025

How did you get the build issues? They might depend on the OS and/or the Python version. I'd like to reproduce them for our build instructions.

@stweil
Copy link
Member

stweil commented Apr 17, 2025

Please address any fixes which are not specific for the UB Mannheim fork with a merge request at https://gitlab.com/scripta/escriptorium/. I also suggest to create separate merge requests there for unrelated changes. This makes reviews easier and improves the chance of getting the changes merged soon.

@stweil
Copy link
Member

stweil commented Apr 30, 2025

@itisAliRH, did you see my question and the remarks?

@stweil
Copy link
Member

stweil commented Jul 29, 2025

@itisAliRH, did you see my question and the remarks?

@itisAliRH, ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants