Better handling of motor faults - #3425
Closed
GrayHoang wants to merge 59 commits into
Closed
Conversation
… motor fault tracking implemented.
GrayHoang
requested review from
itsarune,
sauravbanna and
williamckha
as code owners
February 8, 2025 21:05
GrayHoang
requested review from
a team,
ericlim0329 and
suchirss
and removed request for
a team
March 2, 2025 02:43
1 task
Contributor
Author
|
Need to do some final cleanup. I think I left some debugging stuff and I need to make sure all motors restart 3 times before failing (in the video you can see the affected motor only attempt restart twice). |
…eset 3 times, not 2, when fault detected.
itsarune
reviewed
Jul 14, 2025
itsarune
reviewed
Jul 14, 2025
itsarune
reviewed
Jul 14, 2025
itsarune
reviewed
Jul 14, 2025
itsarune
reviewed
Jul 14, 2025
itsarune
reviewed
Jul 14, 2025
itsarune
reviewed
Jul 14, 2025
itsarune
left a comment
itsarune
left a comment
Contributor
There was a problem hiding this comment.
left some more comments
…e into HandleMotorFault
Scan all motors per call to poll, rather than one per call
…e into HandleMotorFault
Contributor
Author
|
I'm going to need someone to test this in the mezz, or I can do it in about 2 weeks. |
itsarune
reviewed
Jul 18, 2025
…rs per call to poll, rather than one per call" This reverts commit 8271f50
itsarune
reviewed
Jul 30, 2025
itsarune
left a comment
itsarune
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Let me know when you've field tested it and I'll approve!
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill out the following before requesting review on this PR
Description
See #3408
https://github.com/user-attachments/assets/a77848b3-ee4a-4df8-ad6d-0fa36bc76db8
Changes motor fault handling to a per motor control.
Allows for faulty motors to be disabled without crashing thunderloop.
Disabled motors freewheel and are no longer checked for further issues. They will not be given commands to run.
Testing Done
Tested on robot. When fault is detected, movement halts and motors attempt to restart three times before disabling the affected motor and reinitializing all other motors.
Resolved Issues
Resolves #3408
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue