Fixes Onboard CLI import errors - #3495
Merged
Andrewyx merged 2 commits intoSep 19, 2025
Merged
Conversation
Andrewyx
requested review from
itsarune,
sauravbanna and
williamckha
as code owners
September 18, 2025 23:27
Mr-Anyone
approved these changes
Sep 19, 2025
williamckha
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR gets robot diagnostics CLI working on the PIs robots again after migration in #3459.
The fix for the linked resolved issue do not inherently pertain to the changes in this PR. Instead, the fix for that seemed to be to
rm -rfthe/opt/tbotspythonvirtual environment and rerunsetup_pi.yml. The reason for this is due to the accumulation of old python version within thevenvover the years. This results in a python mismatch and the CPython crash.Warning
ALL ROBOTS MUST UNDERGO THE CLEARING OF
/opt/tbotspythonTO WORK. Ideally, we should add this deletion tosetup_pi.ymlAdditionally, it seems some subtle changes were introduced since the Bazel 8 migration with resulted in the declaration of paths to become more strict. Hence, the changes in this PR reflect this and introduce module names to address this.
Testing Done
Works on robot. Status visible, commands can be issued, no errors produced.
Run-able with
./tbots_cliResolved Issues
Resolves #3494
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue