Skip to content

Fixes Onboard CLI import errors - #3495

Merged
Andrewyx merged 2 commits into
UBC-Thunderbots:masterfrom
Andrewyx:Andrewyx/Fix_diagnostic_CLI_imports
Sep 19, 2025
Merged

Fixes Onboard CLI import errors#3495
Andrewyx merged 2 commits into
UBC-Thunderbots:masterfrom
Andrewyx:Andrewyx/Fix_diagnostic_CLI_imports

Conversation

@Andrewyx

Copy link
Copy Markdown
Contributor

Description

This PR gets robot diagnostics CLI working on the PIs robots again after migration in #3459.

The fix for the linked resolved issue do not inherently pertain to the changes in this PR. Instead, the fix for that seemed to be to rm -rf the /opt/tbotspython virtual environment and rerun setup_pi.yml. The reason for this is due to the accumulation of old python version within the venv over the years. This results in a python mismatch and the CPython crash.

Warning

ALL ROBOTS MUST UNDERGO THE CLEARING OF /opt/tbotspython TO WORK. Ideally, we should add this deletion to setup_pi.yml

Additionally, it seems some subtle changes were introduced since the Bazel 8 migration with resulted in the declaration of paths to become more strict. Hence, the changes in this PR reflect this and introduce module names to address this.

Testing Done

Works on robot. Status visible, commands can be issued, no errors produced.
Run-able with ./tbots_cli

Resolved Issues

Resolves #3494

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@Andrewyx
Andrewyx merged commit fe44d6a into UBC-Thunderbots:master Sep 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Robot Diagnostics CLI fails import with PyFrame_GetCode

4 participants