Release Cron Fix - #3595
Conversation
| version: ${{ steps.bump_logic.outputs.tag }} | ||
| tag: ${{ steps.bump_logic.outputs.tag }} | ||
|
|
||
| - name: Create GitHub Release |
There was a problem hiding this comment.
nit: why do we no longer need to do this?
There was a problem hiding this comment.
I'm more confused as to why it was necessary in the first place. Isn't it being released in the later code anyways? To be honest, I don't really understand the way CI works here
There was a problem hiding this comment.
So the problem I encountered was that if you try and create a release directly, it won't allow you to append multiple files to the output. You have to create a draft release and attach all the files to it, then release it. Not sure if your fix will run into this issue, but that's why it was there in the first place.
| if [ "${{ github.event_name }}" != "workflow_dispatch" ] && [ "$LATEST_TAG" != "v0.0.0" ]; then | ||
| TAG_DATE=$(git log -1 --format=%as "$LATEST_TAG") | ||
| TODAY=$(date +%Y-%m-%d) | ||
| echo "Tag Date: $TAG_DATE, Today: $TODAY" |
There was a problem hiding this comment.
nit: will we encounter this case? i assume if the daily intersects with the less frequent releases?
There was a problem hiding this comment.
I think this is to prevent double release when Sunday lines up with first of the month.
sauravbanna
left a comment
sauravbanna
left a comment
There was a problem hiding this comment.
LGTM, i assume this works but the logical flow of everything makes sense and is understandable
|
@GrayHoang Can you verify this is working as expected? |
GrayHoang
left a comment
GrayHoang
left a comment
There was a problem hiding this comment.
Logic looks good, so I think we can give it a shot and see what happens on Sunday.
| if [ "${{ github.event_name }}" != "workflow_dispatch" ] && [ "$LATEST_TAG" != "v0.0.0" ]; then | ||
| TAG_DATE=$(git log -1 --format=%as "$LATEST_TAG") | ||
| TODAY=$(date +%Y-%m-%d) | ||
| echo "Tag Date: $TAG_DATE, Today: $TODAY" |
There was a problem hiding this comment.
I think this is to prevent double release when Sunday lines up with first of the month.
3 participants
Description
Fixes the release numbering system
Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue