Skip to content

Closed Loop Fix - #3598

Merged
Andrewyx merged 3 commits into
UBC-Thunderbots:masterfrom
Andrewyx:Andrewyx/Closed_loop_fix
Feb 14, 2026
Merged

Closed Loop Fix#3598
Andrewyx merged 3 commits into
UBC-Thunderbots:masterfrom
Andrewyx:Andrewyx/Closed_loop_fix

Conversation

@Andrewyx

@Andrewyx Andrewyx commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes the issue where path layer lines are polygonal. See #3522 for reference as this builds off of that task

Testing Done

Paths no longer form a closed loop (green).

image

Resolved Issues

Resolves #3530

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@Mr-Anyone Mr-Anyone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I should have fix this a lot time ago.

@Mr-Anyone Mr-Anyone mentioned this pull request Feb 12, 2026
4 tasks
@Mr-Anyone

Copy link
Copy Markdown
Contributor

I just closed #3522, sorry for leaving it open for so long.

@nycrat nycrat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the only question I have is if it makes sense to call the line strip "1D" ?

@StarrryNight

Copy link
Copy Markdown
Contributor

Good work. I never knew the closed loop path lines were supposed to be just one line...

@Andrewyx
Andrewyx merged commit 5423717 into UBC-Thunderbots:master Feb 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trajectory is a closed loop

5 participants