Closed Loop Fix - #3598
Merged
Andrewyx merged 3 commits intoFeb 14, 2026
Merged
Conversation
williamckha
approved these changes
Feb 11, 2026
Mr-Anyone
approved these changes
Feb 12, 2026
Mr-Anyone
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this. I should have fix this a lot time ago.
Contributor
|
I just closed #3522, sorry for leaving it open for so long. |
nycrat
approved these changes
Feb 12, 2026
nycrat
left a comment
Member
There was a problem hiding this comment.
Looks good, the only question I have is if it makes sense to call the line strip "1D" ?
Contributor
|
Good work. I never knew the closed loop path lines were supposed to be just one line... |
StarrryNight
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue where path layer lines are polygonal. See #3522 for reference as this builds off of that task
Testing Done
Paths no longer form a closed loop (green).
Resolved Issues
Resolves #3530
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue