Skip to content

Update bazel skylib version - #3817

Merged
williamckha merged 2 commits into
UBC-Thunderbots:masterfrom
nycrat:avah/update_bazel_skylib_version
Jul 1, 2026
Merged

Update bazel skylib version#3817
williamckha merged 2 commits into
UBC-Thunderbots:masterfrom
nycrat:avah/update_bazel_skylib_version

Conversation

@nycrat

@nycrat nycrat commented Jun 30, 2026

Copy link
Copy Markdown
Member

Description

Resolves the following warning which is displayed with every bazel command:

WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.8.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 0 packages loaded

Testing Done

bazel_skylib just provides helper rules for bazel BUILD files. I'm just assuming if robot software builds then this change should not break anything else

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@nycrat
nycrat changed the base branch from robocup_2026 to master June 30, 2026 04:14
@nycrat
nycrat changed the base branch from master to robocup_2026 June 30, 2026 05:51
@nycrat
nycrat changed the base branch from robocup_2026 to master June 30, 2026 05:51
@williamckha
williamckha merged commit 636760c into UBC-Thunderbots:master Jul 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants