Skip to content

Run ci for robocup branches - #3820

Merged
williamckha merged 1 commit into
UBC-Thunderbots:robocup_2026from
nycrat:avah/robocup_ci
Jun 30, 2026
Merged

Run ci for robocup branches#3820
williamckha merged 1 commit into
UBC-Thunderbots:robocup_2026from
nycrat:avah/robocup_ci

Conversation

@nycrat

@nycrat nycrat commented Jun 30, 2026

Copy link
Copy Markdown
Member

Description

Testing Done

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@williamckha
williamckha merged commit 4d0dcc7 into UBC-Thunderbots:robocup_2026 Jun 30, 2026
7 of 8 checks passed
williamckha added a commit that referenced this pull request Jul 4, 2026
* Fix default gamecontroller interface for macos

* Only apply dynamic ports for gamecontroller when parallel

* Run ci for robocup branches (#3820)

* Revert "Run ci for robocup branches (#3820)"

This reverts commit 4d0dcc7.

* nit

---------

Co-authored-by: Eric Xiao <ericxiao0000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants