SVCD::subscribe [NOT READY] #37
Conversation
| lua_pushnumber(L, 2530); | ||
| lua_call(L, 4, 0); | ||
| lua_pushnumber(L, ivkid); | ||
| return 0; |
There was a problem hiding this comment.
You should return the number of results (1 in this case).
men in #000000
There was a problem hiding this comment.
Looks like you removed SVCD before constructing your message and sending it & wasn't sure if you could do that.
Sincerely, Running with Scissors
|
lua_getfield(L, -1, "ivkid"); -team birdpeople |
|
@jenniferdai the -1 is referring to the placement of the table being indexed to by "ivkid", so it should be fine -TBD |
| lua_getfield(L, -1, "ivkid"); | ||
|
|
||
| uint16_t ivkid = luaL_checkinteger(L, -1); | ||
| lua_pop(L, 1); |
There was a problem hiding this comment.
Nit-picking, but I don't think you need to do this per se. Can't you just leave this on the stack and have it cleaned up later?
- PB for your Jelly or, The Perfect Storm
There was a problem hiding this comment.
Changed to stack cleanup to the lua call machinery
|
See #45 for the revised version |
|
superseded by #45 |
Implemented subscribe function in C.