Skip to content

docs: blurb git-jupyter (closes #348) - #531

Merged
d-morrison merged 2 commits into
mainfrom
feat/issue-348-blurb-git-jupyter
Sep 9, 2026
Merged

docs: blurb git-jupyter (closes #348)#531
d-morrison merged 2 commits into
mainfrom
feat/issue-348-blurb-git-jupyter

Conversation

@d-morrison

@d-morrison d-morrison commented Sep 8, 2026

Copy link
Copy Markdown
Member

Closes #348

Adds a curated blurb under ## Resources for Python in resources.qmd linking to Jupyter Notebooks in a Git Repository by Matthias Geier, detailing workflows for stripping cell outputs before committing and sharing executed notebooks.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1-2-g6ad689f
Preview removed because the pull request was closed.
2026-09-09 01:55 UTC

@d-morrison
d-morrison marked this pull request as ready for review September 9, 2026 01:43
@claude

claude Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Claude finished @d-morrison's task in 2m 12s —— View job


Code Review

  • Gather context and read changed files
  • Review resources.qmd changes
  • Review inst/WORDLIST changes
  • Check for AI hallucinations (invented URLs, package names, etc.)
  • Post findings

Overall verdict: LGTM with one suggestion. The change is small, clean, and well-formatted. No hallucinations detected.


resources.qmd (lines 97–100)

The new entry follows all repo conventions:

  • Semantic line breaks at logical phrase boundaries ✓
  • No non-ASCII punctuation (no curly quotes, no em dashes outside ---) ✓
  • Attribution style ("guide by Matthias Geier") is consistent with the existing r-ci and shinycoreci entries ✓
  • No raw HTML ✓

One suggestion — section placement. The entry is added to "Resources for Python", but its content is primarily about Git workflows for Jupyter notebooks (stripping cell outputs before committing, sharing strategies). The "Resources for Git & Github" section (line 67) might be a more discoverable home for a reader coming to that section with a Git+notebook problem. Either placement is defensible since Jupyter is a Python tool, but the resource's core value is the Git side of things.

inst/WORDLIST

Geier is inserted at line 42, between GUIs and Ghostty. The file uses C-locale sort order (uppercase before lowercase), so the ordering GUIs (U=85) < Geier (e=101) < Ghostty (h=104) is correct ✓

Hallucination check

  • URL https://mgeier.github.io/git-jupyter.html — GitHub Pages URL for user mgeier; attribution to "Matthias Geier" is consistent with that handle and the name is a well-known resource in the Jupyter ecosystem. No fabrication detected.
  • The description ("stripping cell outputs before committing", "sharing executed notebooks") accurately characterizes the guide's scope.

Comment thread resources.qmd
@d-morrison

Copy link
Copy Markdown
Member Author

🤖 Antigravity Agent Report

Summary of Changes

The pull request adds an external reference under the ## Resources for Python section in resources.qmd pointing to Matthias Geier's guide, Jupyter Notebooks in a Git Repository. The entry summarizes strategies for managing notebooks in Git repositories, including workflows for stripping cell outputs before committing and sharing executed notebooks. Additionally, Geier is added to inst/WORDLIST in proper ASCII sort order.

Findings

No actionable findings identified.
[FINDINGS_COUNT: 0]

Verdict: Ready for merge

Reviewed-Commit: ca75201

Posted by Antigravity (AI agent) --- not written by a human.

@d-morrison
d-morrison merged commit 6258197 into main Sep 9, 2026
12 checks passed
@d-morrison
d-morrison deleted the feat/issue-348-blurb-git-jupyter branch September 9, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

blurb https://mgeier.github.io/git-jupyter.html

1 participant