Feat/issue432/revert to est seroincidence

[kristinawlai]

Revert function names to be consistent with decision to use "seroincidence"

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
R/utils.R	60.00%	4 Missing ⚠️
R/autoplot.seroincidence.R	0.00%	1 Missing ⚠️
R/est_seroincidence.R	66.66%	1 Missing ⚠️

Files with missing lines	Coverage Δ
R/estimate_scr_by.R	91.94% <100.00%> (ø)
R/print.seroincidence.R	100.00% <ø> (ø)
R/summary.seroincidence.R	82.35% <ø> (ø)
R/autoplot.seroincidence.R	0.00% <0.00%> (ø)
R/est_seroincidence.R	64.84% <66.66%> (ø)
R/utils.R	31.25% <60.00%> (-0.50%)	⬇️

[github-actions]

📕 Preview documentation for this PR has been cleaned up.

[kristinawlai]

Notes... I tests pass in R studio but not in GitHub checks. I think the the issue in is estimate_scr_by lines 202 and/or 239.

202: what = estimate_scr <- I had changed this to 'est_seroincidence by then was seeing errors in tests saying "object est_seroincidence could not be found". I reverted to estimate_scr and tests passed. However, now on GitHub tests, errors say "object estimate_scr cannot be found".

239: what = est_seroincidence <- this was updated but doesn't seem to be causing issues?

[kristinawlai]

@d-morrison Should be ready for review. The remaining failing lints are from internal function names in snake case.

[d-morrison]

Looks good!