Skip to content

Revert to est_seroincidence_by()#439

Closed
kristinawlai wants to merge 20 commits into
mainfrom
feat/issue432/revert-to-est_seroincidence_by
Closed

Revert to est_seroincidence_by()#439
kristinawlai wants to merge 20 commits into
mainfrom
feat/issue432/revert-to-est_seroincidence_by

Conversation

@kristinawlai

Copy link
Copy Markdown
Collaborator

Update estimate_scr --> est_seroincidence_by()

@codecov

codecov Bot commented Jun 17, 2025

Copy link
Copy Markdown

❌ 12 Tests Failed:

Tests completed Failed Passed Skipped
81 12 69 0
View the top 3 failed test(s) by shortest run time
est_seroincidence_by::results_are_consistent_with_strata_NULL_
Stack Traces | 0.022s run time
Error in `estimate_scr(pop_data = sees_pop_data_pk_100, sr_params = typhoid_curves_nostrat_100, 
    noise_param = example_noise_params_pk, antigen_isos = c("HlyE_IgG", 
        "HlyE_IgA"))`: could not find function "estimate_scr"
print.seroincidence::results_are_consistent
Stack Traces | 0.033s run time
Error in `estimate_scr(pop_data = xs_data, sr_params = curve, noise_params = noise, 
    antigen_isos = c("HlyE_IgG", "HlyE_IgA"), )`: could not find function "estimate_scr"
est_seroincidence_by::a_warning_is_produced_when_strata_NULL
Stack Traces | 0.049s run time
Error in `estimate_scr(pop_data = pop_data, sr_params = curve_params, noise_params = noise_params, 
    lambda_start = lambda_start, antigen_isos = antigen_isos, 
    build_graph = build_graph, verbose = verbose, ...)`: could not find function "estimate_scr"
Backtrace:
    x
 1. \-testthat::expect_snapshot(...) at test-est_seroincidence_by.R:244:5
 2.   \-rlang::cnd_signal(state$error)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions

github-actions Bot commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

📕 Preview documentation for this PR has been cleaned up.

@kristinawlai

Copy link
Copy Markdown
Collaborator Author

Stuck with these failed tests (8 of these):
image

Ran into a similar issue in PR 432 (rename estimate_scr() to est_seroincidence()) with parallel processing, but seems to be something different here. PR 432 fixed by reverting to "what = estimate_scr" in this commit: 45e5436

Merge branch 'main' into feat/issue432/revert-to-est_seroincidence_by

# Conflicts:
#	NAMESPACE
#	R/est_seroincidence_by.R
#	man/est_seroincidence_by.Rd
#	pkgdown/_pkgdown.yml
#	vignettes/articles/simulate_xsectionalData.qmd
@kristinawlai

Copy link
Copy Markdown
Collaborator Author

Moved to new branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant