Skip to content

Test sim kwan em edits#444

Merged
d-morrison merged 52 commits into
mainfrom
test_sim_Kwan_EM_edits
Jun 27, 2025
Merged

Test sim kwan em edits#444
d-morrison merged 52 commits into
mainfrom
test_sim_Kwan_EM_edits

Conversation

@d-morrison

Copy link
Copy Markdown
Member

Thank you for taking the time to submit a pull request!

To maximize the chances of acceptance:

  • The title of your PR should briefly describe the change.
  • The body of your PR should contain Fixes #issue-number (if relevant).
  • Commit/merge messages to be included in NEWS.md should begin with -.
  • Code should follow the tidyverse style guide.
  • Documentation should use roxygen2, with Markdown syntax.
  • Contributions should include unit tests (using testthat).

For more information see Contributing.

Copilot AI review requested due to automatic review settings June 27, 2025 03:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds new simulation scripts (in both .qmd and .r formats) to run seroincidence simulations with different configurations (renew_params TRUE and FALSE) and generates summary statistics tables for PDF output.

  • Added new simulation notebooks and R scripts for simulation runs
  • Updated export statements in R files and NAMESPACE to include sim.cs and sim.cs.multi
  • Adjusted .gitignore to ignore generated PDF files

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
data-raw/test_sim_020425_2.qmd Adds a new simulation notebook for renew_params=TRUE and builds summaries
data-raw/test_sim_020425.r New simulation script with multiple sample sizes and lambda scenarios
data-raw/test_sim_020425.qmd Similar simulation notebook with summary statistics and PDF table output
data-raw/.gitignore Updated to ignore PDF files
R/sim_pop_data_multi.R Updated export for sim.cs.multi
R/sim_pop_data.R Updated export for sim.cs
NAMESPACE Updated to export sim.cs and sim.cs.multi

Comment thread data-raw/test_sim_020425_2.qmd Outdated
# Store each sample size's summary as table
final_table_50 <- generate_final_table(results_50, 50)
final_table_100 <- generate_final_table(results_100, 100)
final_table_150 <- generate_final_table(results_150, 100)

Copilot AI Jun 27, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample size parameter for final_table_150 is set to 100, but it should likely be 150 to match the intended sample size.

Suggested change
final_table_150 <- generate_final_table(results_150, 100)
final_table_150 <- generate_final_table(results_150, 150)

Copilot uses AI. Check for mistakes.
Comment thread data-raw/test_sim_020425_2.qmd Outdated
final_table_50 <- generate_final_table(results_50, 50)
final_table_100 <- generate_final_table(results_100, 100)
final_table_150 <- generate_final_table(results_150, 100)
final_table_200 <- generate_final_table(results_200, 100)

Copilot AI Jun 27, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample size parameter for final_table_200 is set to 100, but it should likely be 200 to accurately reflect the simulation conditions.

Suggested change
final_table_200 <- generate_final_table(results_200, 100)
final_table_200 <- generate_final_table(results_200, 200)

Copilot uses AI. Check for mistakes.
d-morrison and others added 4 commits June 26, 2025 20:51
Co-authored-by: Kwan Ho Lee <ksjlee@ucdavis.edu>
Co-authored-by: Kwan Ho Lee <ksjlee@ucdavis.edu>
@codecov

codecov Bot commented Jun 27, 2025

Copy link
Copy Markdown

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:
Error deserializing json

Caused by:
expected value at line 1 column 1

For more help, visit our troubleshooting guide.


❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
85 1 84 0
View the top 1 failed test(s) by shortest run time
sim_pop_data_multi::_sim_pop_data_multi_works_consistently
Stack Traces | 18.4s run time
Snapshot of `path` to 'sim_pop_data_multi/pop_data_multi.csv' has changed
Run `testthat::snapshot_review('sim_pop_data_multi/')` to review changes
Backtrace:
    x
 1. \-ssdtools:::expect_snapshot_data(pop_data_multi, name = "pop_data_multi") at test-sim_pop_data_multi.R:40:3
 2.   \-testthat::expect_snapshot_file(path, paste0(name, ".csv"), compare = testthat::compare_file_text)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions

github-actions Bot commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

📕 Preview documentation for this PR has been cleaned up.

@d-morrison d-morrison merged commit b64b192 into main Jun 27, 2025
13 of 17 checks passed
@d-morrison d-morrison deleted the test_sim_Kwan_EM_edits branch June 27, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants