Test sim kwan em edits#444
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds new simulation scripts (in both .qmd and .r formats) to run seroincidence simulations with different configurations (renew_params TRUE and FALSE) and generates summary statistics tables for PDF output.
- Added new simulation notebooks and R scripts for simulation runs
- Updated export statements in R files and NAMESPACE to include sim.cs and sim.cs.multi
- Adjusted .gitignore to ignore generated PDF files
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| data-raw/test_sim_020425_2.qmd | Adds a new simulation notebook for renew_params=TRUE and builds summaries |
| data-raw/test_sim_020425.r | New simulation script with multiple sample sizes and lambda scenarios |
| data-raw/test_sim_020425.qmd | Similar simulation notebook with summary statistics and PDF table output |
| data-raw/.gitignore | Updated to ignore PDF files |
| R/sim_pop_data_multi.R | Updated export for sim.cs.multi |
| R/sim_pop_data.R | Updated export for sim.cs |
| NAMESPACE | Updated to export sim.cs and sim.cs.multi |
| # Store each sample size's summary as table | ||
| final_table_50 <- generate_final_table(results_50, 50) | ||
| final_table_100 <- generate_final_table(results_100, 100) | ||
| final_table_150 <- generate_final_table(results_150, 100) |
There was a problem hiding this comment.
The sample size parameter for final_table_150 is set to 100, but it should likely be 150 to match the intended sample size.
| final_table_150 <- generate_final_table(results_150, 100) | |
| final_table_150 <- generate_final_table(results_150, 150) |
| final_table_50 <- generate_final_table(results_50, 50) | ||
| final_table_100 <- generate_final_table(results_100, 100) | ||
| final_table_150 <- generate_final_table(results_150, 100) | ||
| final_table_200 <- generate_final_table(results_200, 100) |
There was a problem hiding this comment.
The sample size parameter for final_table_200 is set to 100, but it should likely be 200 to accurately reflect the simulation conditions.
| final_table_200 <- generate_final_table(results_200, 100) | |
| final_table_200 <- generate_final_table(results_200, 200) |
Co-authored-by: Kwan Ho Lee <ksjlee@ucdavis.edu>
❌ Unsupported file formatUpload processing failed due to unsupported file format. Please review the parser error message:
For more help, visit our troubleshooting guide. ❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
📕 Preview documentation for this PR has been cleaned up. |
Thank you for taking the time to submit a pull request!
To maximize the chances of acceptance:
Fixes #issue-number(if relevant).-.testthat).For more information see Contributing.