Finish updating curve_params to sr_params#449
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
|
…m/UCD-SERG/serocalculator into feat/issue424/update-to-sr_params
Contributor
|
📕 Preview documentation for this PR has been cleaned up. |
Collaborator
Author
|
@d-morrison this should be ready to review, except for 2 lints related to |
d-morrison
approved these changes
Jun 30, 2025
d-morrison
left a comment
d-morrison
left a comment
Member
There was a problem hiding this comment.
Going forward, if example files have \donttest, you can ignore the indentation lints; the lints will be incorrect, because lintr doesn't understand the \donttest{} syntax.
I'll merge this PR as is though; we'll reformat those files the next time they need substantive modifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
argument for 'est_seroincidence_by()' apparently was not changed when we updated 'curve_params' to 'sr_params' in 'est_seroincidence()'.