-
Notifications
You must be signed in to change notification settings - Fork 3
Add cluster-robust standard errors and multi-level clustering support for clustered sampling designs #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add cluster-robust standard errors and multi-level clustering support for clustered sampling designs #475
Changes from 11 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
1c361e1
Initial plan
Copilot b1f321f
Add cluster-robust standard error support to est_seroincidence()
Copilot 46173c1
Fix linting issues and finalize cluster-robust SE implementation
Copilot 28b7b67
Refactor call to compute_cluster_robust_var
d-morrison 44a6bbb
Merge branch 'main' into copilot/adjust-seroincidence-likelihood
d-morrison a19f661
Fix linting issues: replace base R messaging with cli functions
Copilot fa216ed
Add se_type column and compute_icc() function for clustering analysis
Copilot 8567a5e
Fix est_seroincidence_by to support clustering and add comprehensive …
Copilot 01a66de
Extend compute_icc to work with est_seroincidence_by and add antigen_…
Copilot b8a557c
Add min/max cluster sizes and support multi-level clustering
Copilot 1c821c7
Merge branch 'main' into copilot/adjust-seroincidence-likelihood
d-morrison 6034fcf
Address code review feedback: fix cli formatting, line lengths, use m…
Copilot 5e153a3
Refactor clustering code: decompose into separate files per code orga…
Copilot d0fc3d1
Merge branch 'main' into copilot/adjust-seroincidence-likelihood
kaiemjoy 11c3e00
Remove compute_icc() functionality per user request
Copilot 81b14c3
Address code review feedback: remove ICC mentions, extract validation…
Copilot f7b3426
Add clustering documentation to vignettes and mark man/ as linguist-g…
Copilot 33a6826
Increment version and perform quality control checks
Copilot 449f29a
Update vignettes per code review: use actual SEES data variables with…
Copilot 96c583d
Merge branch 'main' into copilot/adjust-seroincidence-likelihood
d-morrison c275206
Fix workflow failures: increment version and address linting issues
Copilot 7f824b1
fix lints
d-morrison c4cb76b
Add version management guidelines to copilot-instructions.md
Copilot ab6426a
Merge branch 'main' into copilot/adjust-seroincidence-likelihood
d-morrison 49b95e1
Fix vignette rendering error: filter noise params to Pakistan in clus…
Copilot 3700ee6
Refactor methodology vignette: move cluster-robust SE content to subfile
Copilot e36a5ef
Improve cluster-robust SE documentation: add symbol definitions and m…
Copilot 3fee00a
more
d-morrison e02d6e7
Enhance vignette: add cross-references and comparisons for clustering…
Copilot 47aa916
Remove multi-level clustering example from enteric fever vignette
Copilot 2cfeb4b
Update conclusions to include clustering findings and reflect actual …
Copilot 10c99ae
Add cluster-robust CIs and p-value to conclusions with country compar…
Copilot 31e636b
Expand cluster-robust comparison to include all 3 countries with pair…
Copilot 581e276
Fix blank CI bounds in vignette conclusions by correcting column names
Copilot 856a241
Merge branch 'main' into copilot/adjust-seroincidence-likelihood
kristinawlai 2522ff0
Update version number to 1.4.0.9007
kristinawlai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number has been incremented from 1.4.0.9003 to 1.4.0.9004, but according to the PR description, the version was bumped to 1.4.0.9002. This inconsistency suggests either the PR description is outdated or multiple version bumps have occurred. Please ensure version numbers are correctly documented and match the PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 6034fcf. Version number corrected to 1.4.0.9002 to match the PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always make sure the dev version is one past the main branch. make a note about this in copilot-instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in c4cb76b. Added "Version Management" section to copilot-instructions.md with clear guidelines:
usethis::use_version('dev')