-
Notifications
You must be signed in to change notification settings - Fork 0
Creating default print methods for class sr_model #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Merge commit '4ee4b99f9f601b2f95fab79fb25a7d781b37e1a7' #Conflicts: # R/Run_Mod.R
Codecov Report❌ Patch coverage is
|
|
📖 https://ucd-serg.github.io/serodynamics/preview/pr114 |
|
I am a little confused with the warning/error I am getting here. It looks like there is a scoping issue relating to the base dataset when using dplyr, but when I fix the issue the tests are producing a warning. It seems like the solution might be in conflicting with each other. Grateful for any help! |
Merge commit 'd0c5aec9a60c1db30076e15b404f82261354cd3a' #Conflicts: # DESCRIPTION # NEWS.md # inst/WORDLIST
Merge commit '512e62a79e4f50fcb28c76d62127d7b1e4e430bf' #Conflicts: # inst/WORDLIST
|
Hi Ezra and Kwan. I checked the snaps and having a hard time finding a solution. It looks like the test for print.sr_model in the github review is producing different median values than when I run the function locally. There also seems to be something going on with autoplot.case_data documention -- this is a new issue and has me stumped as well. Thank you so much for review. These should almost be there! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sschildhauer re: the document error: ggplot2 recently updated to v4.0 and changed a lot of stuff, including documentation, which the documentation for autoplot.case_data() depends on.
Please update ggplot2 and its dependencies on your local machine and re-run document(); once you do that, the changes you introduced in autoplot.case_data.Rd will hopefully go away.
|
@sschildhauer PS - I bet updating ggplot2 will also resolve the snapshot discrepancies; feel free to re-ping me if you're still stuck after that. |
Merge commit '783e92bef4e57e1fa0a000041fe2906346d81e1b'
|
@Kwan-Jenny , can you also take a quick look at this when you get a chance? I recently created an option in the print to make the output similar to that of print.tbl_df. |
I am creating a default print methods for sr_model using the S3 object system. The default print provides the mean value of the posterior distribution for each parameter and all stratification iso_type combinations.