Skip to content

Conversation

@sschildhauer
Copy link
Collaborator

I am creating a default print methods for sr_model using the S3 object system. The default print provides the mean value of the posterior distribution for each parameter and all stratification iso_type combinations.

@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
R/print.sr_model.R 94.73% 1 Missing ⚠️
Files with missing lines Coverage Δ
R/Run_Mod.R 100.00% <ø> (ø)
R/print.sr_model.R 94.73% <94.73%> (ø)

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

📖 https://ucd-serg.github.io/serodynamics/preview/pr114
Preview documentation for this PR (at commit c6de84f)

@sschildhauer
Copy link
Collaborator Author

I am a little confused with the warning/error I am getting here. It looks like there is a scoping issue relating to the base dataset when using dplyr, but when I fix the issue the tests are producing a warning. It seems like the solution might be in conflicting with each other. Grateful for any help!

Merge commit 'd0c5aec9a60c1db30076e15b404f82261354cd3a'

#Conflicts:
#	DESCRIPTION
#	NEWS.md
#	inst/WORDLIST
Merge commit '512e62a79e4f50fcb28c76d62127d7b1e4e430bf'

#Conflicts:
#	inst/WORDLIST
@sschildhauer
Copy link
Collaborator Author

Hi Ezra and Kwan. I checked the snaps and having a hard time finding a solution. It looks like the test for print.sr_model in the github review is producing different median values than when I run the function locally. There also seems to be something going on with autoplot.case_data documention -- this is a new issue and has me stumped as well. Thank you so much for review. These should almost be there!

Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sschildhauer re: the document error: ggplot2 recently updated to v4.0 and changed a lot of stuff, including documentation, which the documentation for autoplot.case_data() depends on.

Please update ggplot2 and its dependencies on your local machine and re-run document(); once you do that, the changes you introduced in autoplot.case_data.Rd will hopefully go away.

@d-morrison
Copy link
Member

d-morrison commented Oct 2, 2025

@sschildhauer PS - I bet updating ggplot2 will also resolve the snapshot discrepancies; feel free to re-ping me if you're still stuck after that.

@sschildhauer
Copy link
Collaborator Author

@Kwan-Jenny , can you also take a quick look at this when you get a chance? I recently created an option in the print to make the output similar to that of print.tbl_df.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants