Skip to content

Conversation

@sschildhauer
Copy link
Collaborator

Updating density dx function. Moving example to inst/. Adding piece to only call single plot. Adding scale_x_10 to plot. Updating test snap.

@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
R/plot_jags_densitydx.R 80.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
R/plot_jags_densitydx.R 96.42% <80.00%> (-3.58%) ⬇️

@github-actions
Copy link

github-actions bot commented Mar 11, 2025

📖 https://ucd-serg.github.io/serodynamics/preview/pr71
Preview documentation for this PR (at commit 57bb2da)

Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far; see comments

@d-morrison d-morrison mentioned this pull request Mar 12, 2025
@sschildhauer
Copy link
Collaborator Author

This is a pull request from a while back with some small changes to the density diagnostic function. Primarily adding the scale_x_10 to the plot.

@sschildhauer sschildhauer requested a review from d-morrison April 28, 2025 19:21
Merge remote-tracking branch 'origin/main' into Density_Dx
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@d-morrison d-morrison removed their request for review May 23, 2025 01:39
@sschildhauer
Copy link
Collaborator Author

It looks like these fixes were actually completed in a separate PR. Okay if I go ahead and pr_finish? @d-morrison

@d-morrison
Copy link
Member

It looks like these fixes were actually completed in a separate PR. Okay if I go ahead and pr_finish? @d-morrison

@sschildhauer Probably fine to delete this branch; just resolve the conflicts first (I peeked at them; they are straightforward to resolve), so that we can get a clear comparison and make sure there's nothing here that we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants