-
Notifications
You must be signed in to change notification settings - Fork 0
Updating density diagnostic function #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… if only one called.
Merge branch 'main' into Density_Dx # Conflicts: # R/plot_jags_densitydx.R
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
|
|
📖 https://ucd-serg.github.io/serodynamics/preview/pr71 |
d-morrison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good so far; see comments
Merge remote-tracking branch 'origin/main' into Density_Dx # Conflicts: # NEWS.md # inst/examples/examples-plot_jags_densitydx.R # man/plot_jags_dens.Rd # tests/testthat/_snaps/plot_jags_densitydx/typhoid-plot.svg
|
This is a pull request from a while back with some small changes to the density diagnostic function. Primarily adding the scale_x_10 to the plot. |
Merge remote-tracking branch 'origin/main' into Density_Dx # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
|
It looks like these fixes were actually completed in a separate PR. Okay if I go ahead and pr_finish? @d-morrison |
@sschildhauer Probably fine to delete this branch; just resolve the conflicts first (I peeked at them; they are straightforward to resolve), so that we can get a clear comparison and make sure there's nothing here that we want. |
Updating density dx function. Moving example to inst/. Adding piece to only call single plot. Adding scale_x_10 to plot. Updating test snap.