Pin use-ai-config on the gha Claude bot callers - #38
Merged
Conversation
Both Morrison-Lab/gha@v2 reusable workflows already default use-ai-config to true, so the @claude bot and the code reviewer were already loading the shared Morrison-Lab/ai-config plugin on every run. Pin the input explicitly in both callers so the intent is visible in the caller and survives any change to the floating @v2 default, and document the plugin-marketplaces/plugins extension path alongside it. Closes #36 Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016nNqPzLPjvrs8NxbqyRdxE
Codecov Report✅ All modified and coverable lines are covered by tests. |
Contributor
|
Claude finished review — View run Confirmed — only 3 files touched, exactly matching the PR description ( Review: Pin
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36.
The premise turned out to be already satisfied
#36 asks whether to wire
use-ai-configinto the twoMorrison-Lab/ghaClaude callers so the reviewer loads the shared corpus directly, on the
understanding that the callers "pass neither, so the reviewer works from
whatever prose the repo happens to carry."
Reading the callee at its pinned tag (the repo's own convention) shows that
premise no longer holds at
@v2. In bothMorrison-Lab/gha/.github/workflows/claude.yml@v2andclaude-code-review.yml@v2,use-ai-configis declared withdefault: true,and the review workflow passes it straight through to
claude-code-action(
use-ai-config: ${{ inputs.use-ai-config }}, ungated, on both the firstand retry review steps). Our two callers omit the input, so it already
resolves to
true. The canonicalghaexample stubs document this directly:So the bot and the reviewer are already installing
ai-config@Morrison-Labon every run. What was actually stale is this repo's caller stubs: they were
copied from an older template that predates these inputs and never mention
ai-config, which is what led to the assumption that it was off.What this PR changes
Rather than a no-op "turn it on," this pins the setting explicitly in both
callers and documents it:
.github/workflows/claude.yml— adds an activewith:block settinguse-ai-config: true(the@claudebot)..github/workflows/claude-code-review.yml— addsuse-ai-config: truealongside the existing
pr-numberinput (the reviewer).plugin-marketplaces/pluginslines to the optionmenu, mirroring the canonical
ghastubs, so the extension path isdiscoverable without being activated.
NEWS.md— an Internal-changes bullet.Before: ai-config on, via an invisible callee default on a floating tag.
After: ai-config on, pinned and self-documenting in the caller — identical
runtime behaviour, but the intent survives any future move of the
@v2default and the next reader won't repeat the "it's off" assumption. This is
consistent with the repo's
copilot-instructions.mdconvention of reading andpinning against the callee at its tag.
The three "worth checking" items from #36
change from this PR: it is already enabled by default, so existing reviews
(e.g. on Add AGENTS.md and CLAUDE.md, and correct the stale copilot-instructions.md #37, Dissertation draft: chapters 1–3 and the two chapter manuscripts #31) already run with the corpus loaded. This PR alters no
runtime input value, only makes the existing one explicit.
copilot-instructions.md? Any conflictwould already be in effect on every review today; none has surfaced. A full
audit of the
ai-configcorpus is out of scope for this caller change.pluginsalongside, oruse-ai-configalone?use-ai-configalone. No additional plugin is needed here, so
plugins/plugin-marketplacesare left documented-but-commented pending anidentified need, keeping this diff to the one decision the issue asked for.
Verification
use-ai-configis a declaredbooleaninput on the callee, sotrueis valid.check-new-line-breaks,lint-markdown's list-item-splice check, and thetable-split check all run clean against the added
NEWS.mdlines (ran thegha@v2scripts locally againstorigin/main).DESCRIPTION'sVersion:is untouched, per theversion-checkconvention.Generated by Claude Code