Fix remaining zizmor ignore statements - #27
Closed
paddyroddy wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions workflows to eliminate remaining zizmor secrets-outside-env ignores by routing secrets through step-level env and referencing them via the env context in with: inputs.
Changes:
- Move
APP_ID/APP_PEMsecrets inmanage-projects.yamlfromwith:into stepenv:and reference them via${{ env.* }}. - Move
LINKS_PRIVATE_KEYinlinks.yamlfromwith:into stepenv:and reference it via${{ env.APP_PEM }}.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/manage-projects.yaml | Routes app credentials through step env to remove zizmor ignore comments. |
| .github/workflows/links.yaml | Routes the private key through step env to remove zizmor ignore comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
This seems to have worked differently to how it did on @paddyroddy repos. Abandoning as little advantage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I introduced these some time ago. I've since learnt the proper way to fix these so makes sense the template, at least, has this fix.