Skip to content

Fix remaining zizmor ignore statements - #27

Closed
paddyroddy wants to merge 2 commits into
mainfrom
zizmor
Closed

Fix remaining zizmor ignore statements#27
paddyroddy wants to merge 2 commits into
mainfrom
zizmor

Conversation

@paddyroddy

@paddyroddy paddyroddy commented Jul 2, 2026

Copy link
Copy Markdown
Member

I introduced these some time ago. I've since learnt the proper way to fix these so makes sense the template, at least, has this fix.

@paddyroddy paddyroddy self-assigned this Jul 2, 2026
@paddyroddy
paddyroddy requested a review from Copilot July 2, 2026 09:53
@paddyroddy paddyroddy added the enhancement New feature or request label Jul 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Actions workflows to eliminate remaining zizmor secrets-outside-env ignores by routing secrets through step-level env and referencing them via the env context in with: inputs.

Changes:

  • Move APP_ID / APP_PEM secrets in manage-projects.yaml from with: into step env: and reference them via ${{ env.* }}.
  • Move LINKS_PRIVATE_KEY in links.yaml from with: into step env: and reference it via ${{ env.APP_PEM }}.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/manage-projects.yaml Routes app credentials through step env to remove zizmor ignore comments.
.github/workflows/links.yaml Routes the private key through step env to remove zizmor ignore comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@paddyroddy

Copy link
Copy Markdown
Member Author

This seems to have worked differently to how it did on @paddyroddy repos. Abandoning as little advantage.

@paddyroddy paddyroddy closed this Jul 2, 2026
@paddyroddy
paddyroddy deleted the zizmor branch July 2, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants