Only retrieve the fast-track population attribute if necessary in enforce_priority_policy
#1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tamuri
commented
Feb 12, 2025
tamuri
commented
- Profiling revealed that around 15% of runtime was being spent in this method
- Specifically, getting all the fast-track attributes for the event's target individual, whether that is needed or not
- Noted that the vast majority of events do not have fast-track priorities (or, in policies that do, not all attributes do).
- We exit after first fast-track attribute encountered.
- Profiling revealed that around 15% of runtime was being spent in `enforce_priority_policy` - Specifically, getting all the fasttrack attributes for the event's target individual, whether that is needed or not - Note that vast majority of events do not have fasttrack priorities (or, in policies that do, not all attributes do)
marghe-molaro
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.