Skip to content

fix(Lua): improves Lua hook thread safety #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
narknon merged 5 commits into from
Oct 25, 2025
Merged

fix(Lua): improves Lua hook thread safety #1054

narknon merged 5 commits into from
Oct 25, 2025

Conversation

@narknon
Copy link
Collaborator

@narknon narknon commented Oct 22, 2025 •
edited
Loading

Description

Massively improves Lua hook thread stability and safety.

Fixes # (issue) (if applicable)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Checklist

  • I have commented my code, particularly in hard-to-understand areas.

Screenshots

Additional context

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025 •
edited
Loading

MSVC-Game__Shipping__Win64 Download Logs
Build Details
Name Information
PR Commit 48c6b83
Merge Commit 54f68a6
Size 45.08 MB
Last Updated Oct 25, 25, 7:28:45 AM UTC
Expires At Nov 8, 25, 7:28:40 AM UTC
MSVC-Game__Debug__Win64 Download Logs
Build Details
Name Information
PR Commit 48c6b83
Merge Commit 54f68a6
Size 54.28 MB
Last Updated Oct 25, 25, 7:34:24 AM UTC
Expires At Nov 8, 25, 7:34:18 AM UTC

@UE4SS UE4SS marked this pull request as draft October 23, 2025 08:58
@narknon narknon marked this pull request as ready for review October 23, 2025 18:29
UE4SS
UE4SS previously requested changes Oct 24, 2025
View reviewed changes
@narknon
fix(Lua): improves Lua hook thread safety
b264e0b 
Addresses potential issues with concurrent access to Lua hook threads by reusing the first created thread for subsequent calls.

This anchors the hook thread to the parent registry only on its first use, preventing redundant registrations.

CURRENTLY BREAKING. WILL LIKELY ADD DEPRECATION
@narknon
fix(Lua): add backwards compat/overloads for the changed callbacks
1c101af
@narknon
refactor(Mods): remove deprecated versions of fire_ functions
740a562
@narknon
refactor(Lua): moves new virtual overloads to avoid abi breaking
8ddbca5 
refactors make_hook api to not return a pair with an unused variable for the 90% use case
@narknon
refactor(Lua): make ensure_hook_thread_exists return thread ref
48c6b83 
rather than use an outparam
@narknon narknon dismissed UE4SS’s stale review October 25, 2025 07:12

review comments implemented

@narknon narknon merged commit 50aa2b0 into main Oct 25, 2025
13 checks passed
@narknon narknon deleted the luathreadsafety branch October 25, 2025 07:13
UE4SS added a commit that referenced this pull request Oct 26, 2025
@UE4SS
fix(Lua): NotifyOnNewObject broke from #1054
204b0bd
@UE4SS UE4SS mentioned this pull request Oct 26, 2025
Merged
1 task
narknon added a commit that referenced this pull request Oct 26, 2025
@narknon
Merge pull request #1065 from UE4SS-RE/notifyonnewobject-fix
e8dc2c8 
fix(Lua): NotifyOnNewObject broke from #1054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UE4SS UE4SS UE4SS left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@narknon @UE4SS