Skip to content

Conversation

@narknon
Copy link
Collaborator

@narknon narknon commented Sep 3, 2025

Description

BREAKING CHANGE: FName string constructors now default to FNAME_Add instead of FNAME_Find.
This means constructors will create new name table entries if the name doesn't exist, rather than returning NAME_None.

  • Changed default FindType parameter from FNAME_Find to FNAME_Add for all string-based constructors
  • Affects FName(const CharType*), FName(StringViewType), and FName(StringViewType, uint32) constructors
  • Existing code relying on FNAME_Find behavior must now explicitly pass it as a parameter

Migration: Code that expects NAME_None for non-existent names should explicitly use FNAME_Find:
Before: FName TestName(TEXT("MayNotExist"));
After: FName TestName(TEXT("MayNotExist"), FNAME_Find);

Fixes # (issue) (if applicable)

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Is/requires documentation update

How has this been tested?

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added the necessary description of this PR to the changelog, and I have followed the same format as other entries.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Additional context

BREAKING CHANGE: FName constructors now create names by default instead of only finding existing ones.
Pass FNAME_Find explicitly to maintain old behavior.
@narknon narknon merged commit d33bcdb into main Sep 3, 2025
13 checks passed
@narknon narknon deleted the !fnamector branch September 3, 2025 18:08
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

MSVC-Game__Debug__Win64 Download Logs
Build Details
Name Information
PR Commit d876a82
Merge Commit 91dc849
Size 47.85 MB
Last Updated Sep 3, 25, 6:25:02 PM UTC
Expires At Sep 17, 25, 6:24:57 PM UTC

MSVC-Game__Shipping__Win64 Download Logs
Build Details
Name Information
PR Commit d876a82
Merge Commit 91dc849
Size 29.38 MB
Last Updated Sep 3, 25, 6:27:33 PM UTC
Expires At Sep 17, 25, 6:27:30 PM UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant