refactor(FName)!: default to FNAME_Add for string constructors #994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE: FName string constructors now default to FNAME_Add instead of FNAME_Find.
This means constructors will create new name table entries if the name doesn't exist, rather than returning NAME_None.
Migration: Code that expects NAME_None for non-existent names should explicitly use FNAME_Find:
Before: FName TestName(TEXT("MayNotExist"));
After: FName TestName(TEXT("MayNotExist"), FNAME_Find);
Fixes # (issue) (if applicable)
Type of change
How has this been tested?
Checklist
Screenshots
Additional context