Skip to content

Update compose.yaml#15

Open
topiga wants to merge 1 commit intomainfrom
bc-immich
Open

Update compose.yaml#15
topiga wants to merge 1 commit intomainfrom
bc-immich

Conversation

@topiga
Copy link
Copy Markdown
Member

@topiga topiga commented Jul 8, 2025

Breaking changes

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Documentation/Content changes

What is the current behavior?

Wrong docker-compose.yaml for immich

Issue Number: N/A

What is the new behavior?

  • Changed the database image, and arguments

Other information

Summary by Sourcery

Update the Immich Docker Compose reference to use the correct Redis image, introduce a DB storage type variable, and simplify the PostgreSQL service configuration.

Enhancements:

  • Switch Redis service to the valkey/valkey image.
  • Add a DB_STORAGE_TYPE environment variable with usage instructions.
  • Remove custom PostgreSQL healthcheck and startup command overrides in the compose file.

Breaking changes
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Jul 8, 2025

Reviewer's Guide

Revises the Immich installation compose documentation by updating the Redis service image reference and simplifying the Postgres service configuration with an optional storage type environment variable.

Class diagram for updated Postgres service configuration

classDiagram
  class PostgresService {
    +POSTGRES_USER: string
    +POSTGRES_DB: string
    +POSTGRES_INITDB_ARGS: string
    +DB_STORAGE_TYPE: string (optional)
    +volumes: string[]
    +restart: string
  }
  class RedisService {
    +image: string (valkey:8-bookworm)
    +container_name: string
    +healthcheck: string
    +restart: string
  }
Loading

File-Level Changes

Change Details Files
Redis image updated
  • Replaced image reference with valkey/valkey:8-bookworm@sha256 digest
docs/ugos/install/immich/compose.yaml
Postgres configuration streamlined
  • Removed healthcheck block
  • Removed custom command overrides
  • Added commented DB_STORAGE_TYPE environment variable
docs/ugos/install/immich/compose.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @topiga - I've reviewed your changes - here's some feedback:

  • The new valkey/valkey:8-bookworm image doesn’t appear to be a Redis image—please confirm or revert to an appropriate Redis image.
  • The instruction to comment out DB_STORAGE_TYPE: 'HDD' may confuse users; consider setting a sensible default or using an explicit flag instead.
  • Removing the Postgres healthcheck and custom postgres command could affect startup reliability—ensure these settings aren’t needed or are handled elsewhere.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `valkey/valkey:8-bookworm` image doesn’t appear to be a Redis image—please confirm or revert to an appropriate Redis image.
- The instruction to comment out `DB_STORAGE_TYPE: 'HDD'` may confuse users; consider setting a sensible default or using an explicit flag instead.
- Removing the Postgres healthcheck and custom `postgres` command could affect startup reliability—ensure these settings aren’t needed or are handled elsewhere.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant