Conversation
Breaking changes
Contributor
Reviewer's GuideRevises the Immich installation compose documentation by updating the Redis service image reference and simplifying the Postgres service configuration with an optional storage type environment variable. Class diagram for updated Postgres service configurationclassDiagram
class PostgresService {
+POSTGRES_USER: string
+POSTGRES_DB: string
+POSTGRES_INITDB_ARGS: string
+DB_STORAGE_TYPE: string (optional)
+volumes: string[]
+restart: string
}
class RedisService {
+image: string (valkey:8-bookworm)
+container_name: string
+healthcheck: string
+restart: string
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @topiga - I've reviewed your changes - here's some feedback:
- The new
valkey/valkey:8-bookwormimage doesn’t appear to be a Redis image—please confirm or revert to an appropriate Redis image. - The instruction to comment out
DB_STORAGE_TYPE: 'HDD'may confuse users; consider setting a sensible default or using an explicit flag instead. - Removing the Postgres healthcheck and custom
postgrescommand could affect startup reliability—ensure these settings aren’t needed or are handled elsewhere.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `valkey/valkey:8-bookworm` image doesn’t appear to be a Redis image—please confirm or revert to an appropriate Redis image.
- The instruction to comment out `DB_STORAGE_TYPE: 'HDD'` may confuse users; consider setting a sensible default or using an explicit flag instead.
- Removing the Postgres healthcheck and custom `postgres` command could affect startup reliability—ensure these settings aren’t needed or are handled elsewhere.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Wrong docker-compose.yaml for immich
Issue Number: N/A
What is the new behavior?
Other information
Summary by Sourcery
Update the Immich Docker Compose reference to use the correct Redis image, introduce a DB storage type variable, and simplify the PostgreSQL service configuration.
Enhancements: