chore: fix/tighten type definition for pcp ws#4430
Closed
wridgeu wants to merge 2 commits intoUI5:masterfrom
Closed
chore: fix/tighten type definition for pcp ws#4430wridgeu wants to merge 2 commits intoUI5:masterfrom
wridgeu wants to merge 2 commits intoUI5:masterfrom
Conversation
Member
|
Thanks a lot @wridgeu for your contribution. We will follow-up with this PR internally and will inform you as soon as the code is updated. |
Member
|
Change prepared 7555073. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fixing/tightening of the PCP WS types for improved consumption when using TS.
Wired the constructor change through to non-pcp ws and also checked "original" types of ws.
When this change lands on new npm types packages, it'll help people using TypeScript.