Spaces can now join the hackspace foundation #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
castaway
commented
Jul 2, 2019
castaway
commented
- Send user-in-space approval email when user changes their space on the profile page
- Show space-joining-foundation form
- Send approval email from space-joining form, to board
- Board can approve/reject space-joining
- Gocardless mandates set up for spaces, and payments requested
- User profile page shows status of their space's joining request / payments
Contributor
|
Exciting! |
main/models/gocardless_mandate.py
Outdated
| return self.get_mandate_for_supporter_membership(supporter_membership).status | ||
|
|
||
| # get_or_create that populates fields from json | ||
| # get all mandate records for space membership |
Contributor
There was a problem hiding this comment.
Indentation here looks out.
unknowndomain
requested changes
Dec 29, 2019
Contributor
unknowndomain
left a comment
unknowndomain
left a comment
There was a problem hiding this comment.
A few comments attached, mostly looks fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.