EEC-149: Implement customised routes for problem selections. by anjurajanHO · Pull Request #103 · UKHomeOffice/evisa-error-correction

anjurajanHO · 2026-07-18T14:47:50Z

What?

Why?

How?

Testing?

Screenshots (optional)

Anything Else? (optional)

Check list

I have reviewed my own pull request
I have written tests (if relevant)

Copilot

Pull request overview

Implements a canonical, ordered “problem” sub-journey with dynamic fork routing and deterministic back-link behavior, aiming to make multi-problem selection flows (including edit journeys) progress consistently.

Changes:

Added canonical problem ordering + utilities to map problem keys ↔ routes and derive owned fields.
Replaced hardcoded /problem forks with generated forks based on selected problems and configured order; added behaviors to preserve problem data across edits and to set custom back links.
Updated summary formatting helpers and summary section parsing to support cleaner output.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
utils/problem-utils.js	Adds mapping/order utilities and helpers for selection/field ownership.
utils/problem-order.js	Defines canonical ordered list of problem keys → target routes.
utils/index.js	Adds `joinNonEmpty` helper and exports it.
utils/build-problem-forks.js	Generates ordered HOF forks for “next selected problem” progression (edit-aware).
apps/eec/sections/summary-data-sections.js	Updates summary parsing/formatting for corrected-details (including selected problems).
apps/eec/index.js	Integrates new behaviours and generated forks across problem-related steps; adds session clearing on check answers.
apps/eec/fields/index.js	Simplifies `problem` checkbox options definition.
apps/eec/behaviours/problem-back-link.js	Adds deterministic back-link logic for the problem sub-journey.
apps/eec/behaviours/clear-problem-session.js	Clears problem-related session fields when no problems are selected.
apps/eec/behaviours/capture-problem-selection.js	Snapshots/restores problem-owned values across edit submissions to avoid unwanted clearing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+      {
+        step: '/problem',
+        field: 'problem',
+        parse: val => Array.isArray(val) ? val.join('\n') : val
+      },


+  const steps = req.form && req.form.options ? req.form.options.steps : null;
+  const sessionSteps = toArray(req.sessionModel.get('steps'));
+
+  if (targetRoute && steps && steps[targetRoute] && Array.isArray(steps[targetRoute].fields)) {
+    return steps[targetRoute].fields;
+  }
+
+  if (targetRoute && steps) {
+    const matchingSessionRoute = sessionSteps.find(stepRoute => {
+      const route = typeof stepRoute === 'string' ? stepRoute : '';
+      return route === targetRoute
+        || route === `${targetRoute}/edit`
+        || route.startsWith(`${targetRoute}/edit/`);
+    });
+
+    if (matchingSessionRoute && steps[targetRoute] && Array.isArray(steps[targetRoute].fields)) {
+      return steps[targetRoute].fields;
+    }
+  }


  return new Intl.DateTimeFormat(config.dateLocales, config.dateFormat).format(dateObj);
 };

+const joinNonEmpty = (values, separator = ' ') => values.filter(Boolean).join(separator);


Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (2)

apps/eec/sections/summary-data-sections.js:39

The summary currently outputs the raw problem-* keys (joined with newlines). The translations already contain user-facing labels for these options, so this will display internal identifiers instead of readable text.

      {
        step: '/problem',
        field: 'problem',
        parse: val => Array.isArray(val) ? val.join('\n') : val
      },

utils/index.js:16

New joinNonEmpty utility is used to format summary values but is not covered by the existing test/unit/utils.test.js suite. Adding a small set of unit tests would lock in expected behaviour (e.g., trimming/blank handling, separators, non-string values).

const joinNonEmpty = (values, separator = ' ') => values.filter(Boolean).join(separator);

  return new Intl.DateTimeFormat(config.dateLocales, config.dateFormat).format(dateObj);
 };

+const joinNonEmpty = (values, separator = ' ') => values.filter(Boolean).join(separator);


+    if (steps && selectedProblems.length === 0) {
+      getProblemFieldsToClear(steps).forEach(fieldName => {
+        req.sessionModel.unset(fieldName);
+      });
+
+      // Keep edit snapshots in sync when no problem journey is selected.
+      req.sessionModel.unset('problem-selection-before-edit');
+      req.sessionModel.unset('problem-selection-current-edit');
+      req.sessionModel.unset('problem-values-before-edit');
+    }


+// Find the next selected problem after the current step.
+// - Non-edit: first later selected problem.
+// - Edit: first later selected problem with missing owned fields.
+const nextSelectedProblem = (req, afterKey = null) => {
+  const selected = new Set(getProblemSelection(req));
+  const afterOrder = getProblemOrder(afterKey);
+  const editJourney = isEditJourney(req);
+
+  for (const problem of ORDERED_PROBLEM_ORDER) {
+    if (problem.order <= afterOrder) {
+      continue;
+    }
+
+    if (!selected.has(problem.key)) {
+      continue;
+    }
+
+    if (!editJourney) {
+      return problem.target;
+    }
+
+    if (problemHasMissingOwnedFields(req, problem.key)) {
+      return problem.target;
+    }
+  }
+
+  return null;
+};


Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

apps/eec/sections/summary-data-sections.js:39

The summary currently renders the raw problem option keys (e.g. problem-full-name) instead of the translated labels. Since translations exist for these options (and getLabel already supports arrays), this will surface internal identifiers to users.

      {
        step: '/problem',
        field: 'problem',
        parse: val => Array.isArray(val) ? val.join('\n') : val
      },

  problem: {
    mixin: 'checkbox-group',
    validate: ['required'],
    isPageHeading: true,
    options: [


@@ -0,0 +1,89 @@
+const { PROBLEM_ORDER } = require('./problem-order');
+
+const ORDERED_PROBLEM_ORDER = PROBLEM_ORDER.slice();


+const isEditJourney = req => {
+  const params = req.params || {};
+  return Boolean(params.edit || params.action === 'edit');
+};


…isplay.

… back link.

…e in CYA page.

…p selected pages in early stages by performing backlink in edit mode.

anjurajanHO requested a review from Copilot July 18, 2026 16:15

Copilot started reviewing on behalf of anjurajanHO July 18, 2026 16:16 View session

Copilot AI reviewed Jul 18, 2026

View reviewed changes

anjurajanHO requested a review from Copilot July 18, 2026 20:17

Copilot started reviewing on behalf of anjurajanHO July 18, 2026 20:17 View session

Copilot AI reviewed Jul 18, 2026

View reviewed changes

anjurajanHO requested a review from Copilot July 19, 2026 18:00

Copilot started reviewing on behalf of anjurajanHO July 19, 2026 18:55 View session

Copilot AI reviewed Jul 19, 2026

View reviewed changes

anjurajanHO added 19 commits July 20, 2026 16:22

EEC-149: Display selected problems on CYA page.

aade056

Make summary page suitable for new routing logic also reordered the d…

2715253

…isplay.

Tidy up on summary page.

9c96187

EEC-149: Added custom behaviour for problem routing, capture data and…

85780e5

… back link.

Fixed some more behaviour when edit.

e8b6462

Added clear problem sessions when journey doesn't include problem pag…

3b0cb3e

…e in CYA page.

EEC-149: Implement customised routes for problem selections.

c3b7309

Forced continue on edit towards problem page.

02dd193

Forced continue on edit towards problem page otherwise a user can ski…

7ca4cb9

…p selected pages in early stages by performing backlink in edit mode.

Moved common function to util file.

dd47c8f

missing field check only need if it is edit Journey.

d87b7b4

Removed redundant code.

a4c803a

Tidy up clear session behaviour.

1ca4390

Call clear problem session behaviour from multiple places

4885fe0

Fix back link from your-evisa-details page.

e0d9e04

Moved redundant normalise function to problem-utils

1ef878e

Removed unwanted continueOnEdit

6700efe

Added order sequencially later to avoid maintanance.

591188e

Added unit test

ff50f80

anjurajanHO force-pushed the EEC-149-problem-routes-customised branch from 204fb13 to ff50f80 Compare July 20, 2026 15:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

EEC-149: Implement customised routes for problem selections.#103

EEC-149: Implement customised routes for problem selections.#103
anjurajanHO wants to merge 19 commits into
eec-phase-4-releasefrom
EEC-149-problem-routes-customised

anjurajanHO commented Jul 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,89 @@
		const { PROBLEM_ORDER } = require('./problem-order');

		const ORDERED_PROBLEM_ORDER = PROBLEM_ORDER.slice();

Uh oh!

Conversation

anjurajanHO commented Jul 18, 2026

What?

Why?

How?

Testing?

Screenshots (optional)

Anything Else? (optional)

Check list

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants