Skip to content

Shape Features#208

Merged
alexdaniel654 merged 9 commits intoUKRIN-MAPS:devfrom
alexdaniel654:feature/shape_features
Jun 29, 2023
Merged

Shape Features#208
alexdaniel654 merged 9 commits intoUKRIN-MAPS:devfrom
alexdaniel654:feature/shape_features

Conversation

@alexdaniel654
Copy link
Member

@alexdaniel654 alexdaniel654 commented Jun 23, 2023

Proposed changes

Adds features derived from segmentations to UKAT. Things like volume, surface area, long and short axis length.

Checklists

  • I have read and followed the CONTRIBUTING document
  • This pull request is from and to the dev branch
  • I have added necessary documentation (if appropriate)
  • I have updated documentation which becomes obsolete after my changes (if appropriate)
  • Files added follow the repository structure (if appropriate)

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #208 (b3fd879) into dev (8eb401c) will increase coverage by 0.03%.
The diff coverage is 98.66%.

@@            Coverage Diff             @@
##              dev     #208      +/-   ##
==========================================
+ Coverage   97.75%   97.79%   +0.03%     
==========================================
  Files          45       47       +2     
  Lines        3744     3892     +148     
==========================================
+ Hits         3660     3806     +146     
- Misses         84       86       +2     
Impacted Files Coverage Δ
ukat/segmentation/shape_features.py 98.38% <98.38%> (ø)
ukat/segmentation/tests/test_shape_features.py 98.83% <98.83%> (ø)
ukat/segmentation/__init__.py 100.00% <100.00%> (ø)
ukat/segmentation/tests/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alexdaniel654 alexdaniel654 merged commit 76b3ee0 into UKRIN-MAPS:dev Jun 29, 2023
@alexdaniel654 alexdaniel654 added this to the v0.7.0 milestone Jun 29, 2023
@alexdaniel654 alexdaniel654 linked an issue Jun 29, 2023 that may be closed by this pull request
@alexdaniel654 alexdaniel654 modified the milestones: v0.7.0, v0.8.0 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add volume features

1 participant