Skip to content

Mapping Fit Signals#221

Merged
alexdaniel654 merged 8 commits intoUKRIN-MAPS:devfrom
alexdaniel654:feature/fit_signals
Mar 21, 2024
Merged

Mapping Fit Signals#221
alexdaniel654 merged 8 commits intoUKRIN-MAPS:devfrom
alexdaniel654:feature/fit_signals

Conversation

@alexdaniel654
Copy link
Member

@alexdaniel654 alexdaniel654 commented Mar 20, 2024

Proposed changes

Adds option to output the simulated signals from the fit model for all mapping methods. This can be generically useful but is going to be needed for model driven registration.

Checklists

  • I have read and followed the CONTRIBUTING document
  • This pull request is from and to the dev branch
  • I have added tests that demonstrate the feature/fix works
  • I have added necessary documentation (if appropriate)
  • I have updated documentation which becomes obsolete after my changes (if appropriate)
  • I have added/updated a notebook to demonstrate the changes (if appropriate)
  • Files added follow the repository structure (if appropriate)

@alexdaniel654 alexdaniel654 self-assigned this Mar 20, 2024
@alexdaniel654 alexdaniel654 added the type:enhancement 🛠️ Improvements to existing features label Mar 20, 2024
@pep8speaks
Copy link

pep8speaks commented Mar 20, 2024

Hello @alexdaniel654, thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated at 2024-03-21 09:48:02 UTC

@codecov
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (0bc7092) to head (0541aa3).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #221      +/-   ##
==========================================
+ Coverage   97.92%   97.96%   +0.04%     
==========================================
  Files          48       48              
  Lines        4333     4433     +100     
==========================================
+ Hits         4243     4343     +100     
  Misses         90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The ROI maps were being produced for didn't actually cover any kidney...
@alexdaniel654 alexdaniel654 added this to the v0.8.0 milestone Mar 21, 2024
@alexdaniel654 alexdaniel654 merged commit d87da4d into UKRIN-MAPS:dev Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement 🛠️ Improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants