SE-EPI T1 Acquisition Orders#238
Merged
alexdaniel654 merged 8 commits intoUKRIN-MAPS:devfrom Feb 20, 2025
Merged
Conversation
First draft, no tests
No point making a fresh branch for it while I'm already doing T1 modifications
Changed the tss from 10 ms to 100 ms
This was
linked to
issues
Feb 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #238 +/- ##
==========================================
+ Coverage 97.94% 97.97% +0.02%
==========================================
Files 48 48
Lines 4534 4588 +54
==========================================
+ Hits 4441 4495 +54
Misses 93 93 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently ukat only supports ascending slice acquisition orders i.e. ukat assumes the zeroth slice was acquired first, next slice tss later, the next slice 2 x tss later etc. This isn't always the case. In descending acquisitions, the -1th slice is acquired first, the -2th slice tss later etc and in centric acquisitions the slice acquisition order is [4, 2, 0, 1, 3] for a five slice acquisition. ukat should support these options and, ideally, custom acquisition orders.
Checklists