[5주차/챈니] 워크북 제출합니다.#49
Open
12234538 wants to merge 5 commits intoUMC-Inha:챈니/mainfrom
Open
Conversation
jjeunv
reviewed
May 3, 2026
seohyeon0219
reviewed
May 3, 2026
| }); | ||
|
|
||
| // 회원가입 성공 → 로그인 페이지로 이동 | ||
| alert('회원가입 성공! 로그인 해주세요 😊'); |
There was a problem hiding this comment.
전반적으로 잘 짜주신 것 같아요 !
다만 현재 회원가입 성공/실패 피드백이 브라우저 기본 alert로 표시되는데, alert는 브라우저마다 스타일이 다르고 페이지 UI와 동떨어진 디자인으로 보이는 경우가 많아 UX적으로는 아쉬움이 있을 수 있다고 생각합니다 😊
여유가 되시면 alert를 모달로 수정해보셔도 좋을 것 같습니다 ㅎㅎ
haewonwon
reviewed
May 4, 2026
Comment on lines
+41
to
+52
| <button | ||
| onClick={() => navigate('/login')} | ||
| className="px-4 py-2 text-sm border border-gray-300 rounded-md hover:bg-gray-100 transition-colors" | ||
| > | ||
| 로그인 | ||
| </button> | ||
| <button | ||
| onClick={() => navigate('/signup')} | ||
| className="px-4 py-2 text-sm bg-blue-300 text-white rounded-md hover:bg-blue-500 transition-colors" | ||
| > | ||
| 회원가입 | ||
| </button> |
There was a problem hiding this comment.
button을 따로 컴포넌트로 분리하여 중복 스타일, 코드 등을 제거해도 좋을 것 같아요! button뿐만 아니라 input 등 based components도 분리하면 좋답니다!
qkrdmsthff
approved these changes
May 4, 2026
Collaborator
qkrdmsthff
left a comment
qkrdmsthff
left a comment
There was a problem hiding this comment.
LGTM 챈니 이번주도 화이팅입니다!
| import axios from 'axios'; | ||
|
|
||
| const axiosInstance = axios.create({ | ||
| baseURL: 'http://localhost:8000/v1', |
Collaborator
There was a problem hiding this comment.
baseURL 을 하드코딩 하는 것보다 .env 파일에 넣어서 관리하는 것이배포 환경이 바뀔 때에 따라 유연하게 대처할 수 있어요!
| }, | ||
| ); | ||
|
|
||
| export default axiosInstance; |
Collaborator
There was a problem hiding this comment.
현재 코드의 경우, 3개의 요청이 모두 401 에러를 받으면 /refresh 또한 세 번이 호출되게 됩니다! 이는 서버 부하를 유발할 수 있고, 서버 설정에 따라 refreshToken 이 일회용일 경우 첫 번째 이후의 요청은 모두 실패하게 됩니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 워크북 체크리스트
✅ 컨벤션 체크리스트
📌 주안점