[5주차/오스카] 워크북 제출합니다.#51
Open
OscarKang1 wants to merge 2 commits intoUMC-Inha:오스카/mainfrom
Open
Conversation
kcleverp
reviewed
May 2, 2026
aeongiing
reviewed
May 2, 2026
bukyung03
reviewed
May 2, 2026
qkrdmsthff
approved these changes
May 4, 2026
Collaborator
qkrdmsthff
left a comment
qkrdmsthff
left a comment
There was a problem hiding this comment.
LGTM 오스카 이번주도 수고하셨습니다!
그리고 PR 올리실 때 커밋 메세지 규칙 지켜주세용!
| return [storedValue, setValue, removeValue] as const; | ||
| } | ||
|
|
||
| export default useLocalStorage; |
Collaborator
There was a problem hiding this comment.
현재 useLocalStorage 훅은 내부 상태만 변경하고 있어서 외부 상태인 Axios interceptor 에서 로컬 스토리지를 직접 수정했을 때, 리액트 상태가 자동으로 업데이트되지 않는 문제가 발생할 수 있습니다!!
window 의 storage 이벤트를 리스닝하는 브릿지 로직을 추가하여 외부 로직과의 동기화를 보완해보면 좋을 것 같습니다!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 워크북 체크리스트
✅ 컨벤션 체크리스트
📌 주안점