html to markdown #228
html to markdown #228
Conversation
Keep html div-tags necessary for layout but change links and images to markdown. Add a button-frontpage style to keep the same margin between buttons. The "Welcome to UPPMAX" text changes a little as it changed from hard coded size to a level 1 heading.
richelbilderbeek
left a comment
richelbilderbeek
left a comment
There was a problem hiding this comment.
I recommend this change: I enjoy how the HTML go Markdown-ified and I will happily re-use this syntax in the future.
I let the actual approval to @bclaremar and @jayant-yadav: they may want to take notes or double-check.
But I would say: good job @paran1!
|
Neat! I have a tiny formatting improvement: set top margin to 45 px instead of 40 px for the second |
|
@copilot show me a preview of this UI change in comments here. Take a screenshot of the UI. |
|
@jayant-yadav I've opened a new pull request, #230, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
There we go, pushed my space adjustment, I consider this good for merging now. |
jayant-yadav
left a comment
jayant-yadav
left a comment
There was a problem hiding this comment.
gg @paran1 , you have my approval.
|
What a fun case of working together we have here 🥳 ! Well done us 👍 |
Thanks. But what is the point of the copilot stuff? it seems to have added a "Initial plan" commit, and a merge commit, with zero changes, just messes with the commit history. I am leaning toward force-push the branch back to before those two commits. Or am I missing something? |
I did that, then merged. Thanks for all input. |
Change links and images in index.md from html to markdown
Keep div-tags for layout.
Update CSS for this to work. Change so links are not underlined on buttons and add a special class for the buttons on the front page.
The "Welcome to UPPMAX" text looks a little different as it is changed to a regular level 1 heading instead of using hard-coded font size.
Tested using Firefox 144.0.2 and Chrome 142.0.7444.59