Memory regions in Boogie using Data Structure Analysis #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 28, 2024 12:42
…sallowed characters are not included
…s to the external functions
sadrabt
reviewed
Dec 2, 2024
sadrabt
reviewed
Dec 2, 2024
sadrabt
reviewed
Dec 2, 2024
| } | ||
|
|
||
| override def getMergedRegion(address: BigInt, size: Int): Option[MergedRegionDSA] = { | ||
| val dsg = DSATopDown(program.mainProcedure) |
Contributor
There was a problem hiding this comment.
Is size necessary? i don't think it is used by DSA MRA region injector? I think it also makes sense to check if the size is covered by the cell. But I assume this wouldn't hold for examples with globals with disjoint fields (cells) because the size passed as a parameter is the whole global region's size. However, maybe this is not necessary until we have better field-sensitivity implemented
Contributor
|
The rest looks good to me |
Contributor
|
DSA-Regions extra Constraints #280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #249
--memory-regions dsaoption to insert regions based on the Data Structure Analysis results into the Boogie output--memory-regions mraExternalLocationwhich represents the abstract external function or objectDSAMemoryRegionSystemTestsBAPandDSAMemoryRegionSystemTestsGTIRBtest suites which run all SystemTests with the--memory-regions dsaoption setThe DSA-based memory regions are currently able to handle all existing test cases successfully, though it likely does not handle anything involving overlapping accesses successfully yet since the DSA implementation there is not yet finished. It tracks the memory regions by creating a new Map,
accessIndexToSlice, which maps fromMemoryLoads andMemoryStores toSlices representing the indices of the accesses. This mapping is used as the basis for regions, with distinct cells representing distinct memory regions.