Skip to content

Conversation

@ailrst
Copy link
Contributor

@ailrst ailrst commented Dec 5, 2024

This adds a lifted build of cntlm with the PAC (proxy auto configuration) feature disabled and duktape removed, from the release here https://github.com/UQ-PAC/cntlm/releases/tag/build-2-glibc

This reduces its size by 20% and makes it much more manageable for basil to analyse.

@l-kent
Copy link
Contributor

l-kent commented Dec 5, 2024

Is there a reason to include the version with duktape in this? We already have that in the repo as-is

@ailrst
Copy link
Contributor Author

ailrst commented Dec 6, 2024

Just so that it is directly comparable to the example without duktape. The existing versions in the repo don't have any information attached about how they were compiled or with which sourcecode.

@l-kent
Copy link
Contributor

l-kent commented Dec 6, 2024

Do we want the existing versions at all? Do we need a version with duktape at all? I don't think we're ever going to be able to do anything useful with it.

@ailrst
Copy link
Contributor Author

ailrst commented Dec 6, 2024

I found duktape useful for stress testing the (intraprocedural) simplification-pass analyses as it contained a lot of complex behaviour and variety. I think its useful as a worst-case test case for analyses.

I'm not sure if we need the existing versions, but I think its good to keep them as they are known to lift successfully and there have been some changes to the lifter since. E.g. the gtirb here doesn't load because theres a new intobits pattern (fixed in simplification-pass branch).

@l-kent
Copy link
Contributor

l-kent commented Dec 6, 2024

If there's been a breaking change to the lifter, that's really something we want to address in a separate pull request so we can get it merged in faster?

@ailrst
Copy link
Contributor Author

ailrst commented Dec 6, 2024

Yeah. But it was trivial to fix in the simplification-pass branch and isn't simple to cherrypick out the change that fixes it.

@ailrst ailrst marked this pull request as draft December 6, 2024 00:33
@ailrst
Copy link
Contributor Author

ailrst commented Dec 6, 2024

I'm going to re-upload the example as there is also an update to the bap plugin this should be re-built using.

@l-kent
Copy link
Contributor

l-kent commented Dec 6, 2024

What's the point of committing this now then if the main branch can't actually use it?

@ailrst
Copy link
Contributor Author

ailrst commented Dec 6, 2024

  • To use to write the fix to main
  • To merge it into simplification pass which already works and is downstream of main
  • Because the BAP example already works

@l-kent
Copy link
Contributor

l-kent commented Dec 6, 2024

If the old version will be redundant once this is merged and the parser is updated for the GTIRB changes, it'd be simpler to remove the old version and update the parser all together here?

@ailrst ailrst force-pushed the cntlm-noduk-example branch from 362eacb to 64cbb32 Compare January 29, 2025 03:44
@ailrst ailrst force-pushed the cntlm-noduk-example branch from 64cbb32 to 1867aa3 Compare January 29, 2025 03:45
@ailrst ailrst marked this pull request as ready for review January 29, 2025 03:46
@ailrst ailrst merged commit fee4ee2 into main Jan 29, 2025
2 checks passed
@ailrst ailrst deleted the cntlm-noduk-example branch May 27, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants