add top to symvalues domain #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrinafyi
approved these changes
Sep 30, 2025
Member
katrinafyi
left a comment
katrinafyi
left a comment
There was a problem hiding this comment.
looks reasonable. does using withDefaultValue cause any problems? an alternative would be using LatticeMap.TopMap.
Contributor
Author
|
I dont think it actually uses the top value anymore, I think i should be able to replace line 266 with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix crashes seen in SVA when exprs evaluate to top in the abstract domain and calling
toOffsets, e.g. in cntlm-O3https://github.com/agle/basilbench/tree/main/cntlm-noduk./mill run -i ../tvbins/cntlm-noduk/cntlm-noduk.gts --lifter --dump-il cntlm --simplify --dsa=Just joins a
Constant -> topto the symvalset domain if adding a top constant, theoretically with split-globals it should probably also map all the global bases to top since they could alias? Regardless the assertion should be enough to justify keeping them separate.