Fix recursion issue in IntervalDSA #586
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
katrinafyi
approved these changes
Nov 10, 2025
Member
katrinafyi
left a comment
katrinafyi
left a comment
There was a problem hiding this comment.
Is it worth adding a unit test?
Contributor
Author
|
I'll simplify the case that caused the bug and add it to some of the other test suites too, since it'll be good to make sure this sort of recursion doesn't break anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #581
calledBySCC in the IntervalDSA is recursive, but only checked if the base procedure had strongly connected components, so it wouldn't terminate for programs with recursive functions if those recursive functions called anything else.