Feature/rate function #1082
Draft
Feature/rate function #1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endpoint adds rate/reverse rate options for both value arrays and time series id inputs
MikeNeilson
reviewed
Apr 22, 2025
| import java.time.Instant; | ||
| import java.util.Optional; | ||
|
|
||
| @FormattableWith(contentType = Formats.JSONV1, formatter = JsonV1.class, aliases = {Formats.DEFAULT, Formats.JSON}) |
There was a problem hiding this comment.
FYI, I know this hasn't been official merged in yet, but I don't think anyone had a major issue with the following as the general rule for "data type versioning": https://github.com/USACE/cwms-data-api/pull/959/files#diff-9f37666d47127d069db9e7ef0915049a7d4f4cfafe03f30ddc015ef3c2f3f1ddR1
the aliases are still correct with the above, we've just been overusing JSONV1 vs JSONV2
|
I don't see rate limiting at this time. I assume that will be done before the PR is marked as ready for review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #641