Feature/1392 use flogger #1477
Open
Feature/1392 use flogger #1477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or office if the connection is read-only.
MikeNeilson
previously approved these changes
Dec 2, 2025
| } catch (Exception e) { | ||
| throw new DataAccessException("Unable to set user session. " | ||
| + "user empty = " + user.isEmpty(), e); | ||
| try { |
Contributor
There was a problem hiding this comment.
well, it might work. presumably if the database is in read only mode the oracle jdbc driver would actually respond as such.
Collaborator
Author
There was a problem hiding this comment.
I was hoping this would fix the issue reported in #991
I didn't explicitly test that case but it seemed like in #991 the connection was read-only and the user was set. Should I take this out and just get the flogger changes merged first? The only reason I include it is b/c flogger gives us the option to easily do .atMostEvery(...) and (hopefully) not fill up their logs. 8Gb/day is kinda impressive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1392